Merge branch 'bugfix/S3C-1286-bucket-name-length' into tmp/octopus/w/7.7/bugfix/S3C-1286-bucket-name-length

lib/s3routes/routesUtils.js

@@ -886,7 +886,7 @@ const routesUtils = {
         // eslint-disable-next-line no-useless-escape
         const dnsRegex = new RegExp(/^[a-z0-9]+((\.|\-+)[a-z0-9]+)*$/);
         // Must be at least 3 and no more than 63 characters long.
-        if (bucketname.length < 3 || bucketname.length > 63) {
+        if (bucketname.length < 3 || bucketname.length > 255) {
             return false;
         }
         // Certain prefixes may be reserved, for example for shadow buckets

tests/unit/s3routes/routesUtils/isValidBucketName.js

@@ -34,9 +34,8 @@ describe('routesUtils.isValidBucketName', () => {
     });
 
     it('should return false if bucketname is greater than ' +
-        '63 characters long', () => {
+        '255 characters long', () => {
-        const longString = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' +
+        const longString = 'a'.repeat(256);
-            'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
         const result =
             routesUtils.isValidBucketName(longString, prefixBlacklist);
         assert.strictEqual(result, false);
@@ -79,6 +78,14 @@ describe('routesUtils.isValidBucketName', () => {
         assert.strictEqual(result, true);
     });
 
+    it('should return true if bucketname is greater than 63 characters ' +
+        'but less than 256', () => {
+        const longString = 'a'.repeat(64);
+        const result =
+            routesUtils.isValidBucketName(longString, prefixBlacklist);
+        assert.strictEqual(result, true);
+    });
+
     describe('should return true when bucket name has valid' +
         ' combination of dots and hyphens', () => {
         validBucketNamesWithDotsAndHyphens.forEach(bucketName => {