Compare commits
46 Commits
developmen
...
ft/sticky-
Author | SHA1 | Date |
---|---|---|
Lauren Spiegel | b72fe0370b | |
Cloud User | 469e504712 | |
Alex Rodrigues | c030476a20 | |
Alex Rodrigues | c506d7e7ae | |
Alex Rodrigues | 37bc59555d | |
Lauren Spiegel | 1d76f42a2e | |
Lauren Spiegel | 7ca08da723 | |
Lauren Spiegel | 235941a2b7 | |
Lauren Spiegel | 26054af9b0 | |
Lauren Spiegel | 1e00fefa98 | |
Cloud User | f257c70a8d | |
Lauren Spiegel | 486b899f67 | |
Cloud User | 38e780ce96 | |
Cloud User | d21112cf0e | |
Lauren Spiegel | 941acf8246 | |
Lauren Spiegel | f9f1bca84f | |
Cloud User | a5a9738993 | |
Lauren Spiegel | 2841ff31bc | |
Lauren Spiegel | 0cf2d7a8d9 | |
Lauren Spiegel | bcbd13bfa9 | |
Lauren Spiegel | 71cae881fe | |
Lauren Spiegel | f26ff323b2 | |
Lauren Spiegel | f3c3bc221d | |
Lauren Spiegel | c7d3c9b8cc | |
Lauren Spiegel | 41c55ba940 | |
Lauren Spiegel | 2d92e0752a | |
Lauren Spiegel | 0b9ee1fb45 | |
Lauren Spiegel | 9c5fdc87ff | |
Lauren Spiegel | 1e0f1fda5c | |
Lauren Spiegel | 9a9724c2f8 | |
Lauren Spiegel | a5167d07d8 | |
Lauren Spiegel | 51469633fb | |
Lauren Spiegel | 3a40cd996a | |
Lauren Spiegel | ab39d1c772 | |
Lauren Spiegel | 46dd5d61d7 | |
Lauren Spiegel | 18663d0173 | |
Lauren Spiegel | eb93c5c5be | |
Lauren Spiegel | 805c85eed5 | |
Lauren Spiegel | 975165ec96 | |
Lauren Spiegel | 810a3cd2de | |
Lauren Spiegel | 35f578f599 | |
Lauren Spiegel | 273b14c7a9 | |
Lauren Spiegel | 5ff4db0497 | |
Lauren Spiegel | bd45bd73f3 | |
Lauren Spiegel | 526c75e260 | |
Cloud User | 77bde1f2c3 |
|
@ -0,0 +1,3 @@
|
|||
node_modules
|
||||
localData/*
|
||||
localMetadata/*
|
|
@ -0,0 +1,97 @@
|
|||
#!/bin/sh
|
||||
// 2>/dev/null ; exec "$(which nodejs 2>/dev/null || which node)" "$0" "$@"
|
||||
'use strict'; // eslint-disable-line strict
|
||||
|
||||
const { auth } = require('arsenal');
|
||||
const commander = require('commander');
|
||||
|
||||
const http = require('http');
|
||||
const https = require('https');
|
||||
const logger = require('../lib/utilities/logger');
|
||||
|
||||
function _performSearch(host,
|
||||
port,
|
||||
bucketName,
|
||||
query,
|
||||
accessKey,
|
||||
secretKey,
|
||||
verbose, ssl) {
|
||||
const escapedSearch = encodeURIComponent(query);
|
||||
const options = {
|
||||
host,
|
||||
port,
|
||||
method: 'GET',
|
||||
path: `/${bucketName}/?search=${escapedSearch}`,
|
||||
headers: {
|
||||
'Content-Length': 0,
|
||||
},
|
||||
rejectUnauthorized: false,
|
||||
};
|
||||
const transport = ssl ? https : http;
|
||||
const request = transport.request(options, response => {
|
||||
if (verbose) {
|
||||
logger.info('response status code', {
|
||||
statusCode: response.statusCode,
|
||||
});
|
||||
logger.info('response headers', { headers: response.headers });
|
||||
}
|
||||
const body = [];
|
||||
response.setEncoding('utf8');
|
||||
response.on('data', chunk => body.push(chunk));
|
||||
response.on('end', () => {
|
||||
if (response.statusCode >= 200 && response.statusCode < 300) {
|
||||
logger.info('Success');
|
||||
process.stdout.write(body.join(''));
|
||||
process.exit(0);
|
||||
} else {
|
||||
logger.error('request failed with HTTP Status ', {
|
||||
statusCode: response.statusCode,
|
||||
body: body.join(''),
|
||||
});
|
||||
process.exit(1);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
auth.client.generateV4Headers(request, { search: query },
|
||||
accessKey, secretKey, 's3');
|
||||
if (verbose) {
|
||||
logger.info('request headers', { headers: request._headers });
|
||||
}
|
||||
request.end();
|
||||
}
|
||||
|
||||
/**
|
||||
* This function is used as a binary to send a request to S3 to perform a
|
||||
* search on the objects in a bucket
|
||||
*
|
||||
* @return {undefined}
|
||||
*/
|
||||
function searchBucket() {
|
||||
// TODO: Include other bucket listing possible query params?
|
||||
commander
|
||||
.version('0.0.1')
|
||||
.option('-a, --access-key <accessKey>', 'Access key id')
|
||||
.option('-k, --secret-key <secretKey>', 'Secret access key')
|
||||
.option('-b, --bucket <bucket>', 'Name of the bucket')
|
||||
.option('-q, --query <query>', 'Search query')
|
||||
.option('-h, --host <host>', 'Host of the server')
|
||||
.option('-p, --port <port>', 'Port of the server')
|
||||
.option('-s', '--ssl', 'Enable ssl')
|
||||
.option('-v, --verbose')
|
||||
.parse(process.argv);
|
||||
|
||||
const { host, port, accessKey, secretKey, bucket, query, verbose, ssl } =
|
||||
commander;
|
||||
|
||||
if (!host || !port || !accessKey || !secretKey || !bucket || !query) {
|
||||
logger.error('missing parameter');
|
||||
commander.outputHelp();
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
_performSearch(host, port, bucket, query, accessKey, secretKey, verbose,
|
||||
ssl);
|
||||
}
|
||||
|
||||
searchBucket();
|
14
config.json
14
config.json
|
@ -8,7 +8,9 @@
|
|||
"cloudserver-front": "us-east-1",
|
||||
"s3.docker.test": "us-east-1",
|
||||
"127.0.0.2": "us-east-1",
|
||||
"s3.amazonaws.com": "us-east-1"
|
||||
"s3.amazonaws.com": "us-east-1",
|
||||
"s3-front-lb": "us-east-1",
|
||||
"lb": "us-east-1"
|
||||
},
|
||||
"websiteEndpoints": ["s3-website-us-east-1.amazonaws.com",
|
||||
"s3-website.us-east-2.amazonaws.com",
|
||||
|
@ -44,6 +46,11 @@
|
|||
"healthChecks": {
|
||||
"allowFrom": ["127.0.0.1/8", "::1"]
|
||||
},
|
||||
"livy": {
|
||||
"host": "livy",
|
||||
"port": 8998,
|
||||
"transport": "http"
|
||||
},
|
||||
"metadataClient": {
|
||||
"host": "localhost",
|
||||
"port": 9990
|
||||
|
@ -61,7 +68,8 @@
|
|||
"port": 9991
|
||||
},
|
||||
"recordLog": {
|
||||
"enabled": false,
|
||||
"enabled": true,
|
||||
"recordLogName": "s3-recordlog"
|
||||
}
|
||||
},
|
||||
"whiteListedIps": ["127.0.0.1/8", "::1"]
|
||||
}
|
||||
|
|
|
@ -0,0 +1,8 @@
|
|||
version: '3'
|
||||
|
||||
services:
|
||||
s3-front:
|
||||
image: 127.0.0.1:5000/s3server
|
||||
build: .
|
||||
ports:
|
||||
- "8000:8000"
|
|
@ -414,6 +414,24 @@ class Config extends EventEmitter {
|
|||
}
|
||||
}
|
||||
|
||||
if (config.livy) {
|
||||
this.livy = {};
|
||||
assert.strictEqual(typeof config.livy.host, 'string',
|
||||
'bad config: livy host must be ' +
|
||||
'a string');
|
||||
this.livy.host = config.livy.host;
|
||||
|
||||
assert(Number.isInteger(config.livy.port)
|
||||
&& config.livy.port > 0,
|
||||
'bad config: livy port must be a positive ' +
|
||||
'integer');
|
||||
this.livy.port = config.livy.port;
|
||||
assert(this.livy.transport !== 'http' &&
|
||||
this.livy.transport !== 'https', 'bad config: livy ' +
|
||||
'transport must be either "http" or "https"');
|
||||
this.livy.transport = config.livy.transport;
|
||||
}
|
||||
|
||||
if (config.dataClient) {
|
||||
this.dataClient = {};
|
||||
assert.strictEqual(typeof config.dataClient.host, 'string',
|
||||
|
@ -649,6 +667,17 @@ class Config extends EventEmitter {
|
|||
.concat(config.healthChecks.allowFrom);
|
||||
}
|
||||
|
||||
this.whiteListedIps = [];
|
||||
if (config.whiteListedIps) {
|
||||
assert(Array.isArray(config.whiteListedIps), 'config: invalid ' +
|
||||
'whiteListedIps. whiteListedIps must be array');
|
||||
config.whiteListedIps.forEach(ip => {
|
||||
assert.strictEqual(typeof ip, 'string', 'config: invalid ' +
|
||||
'whiteListedIps. each item in whiteListedIps must be a string');
|
||||
});
|
||||
this.whiteListedIps = config.whiteListedIps;
|
||||
}
|
||||
|
||||
if (config.certFilePaths) {
|
||||
assert(typeof config.certFilePaths === 'object' &&
|
||||
typeof config.certFilePaths.key === 'string' &&
|
||||
|
|
|
@ -0,0 +1,72 @@
|
|||
const Parser = require('node-sql-parser').Parser;
|
||||
const parser = new Parser();
|
||||
const { errors } = require('arsenal');
|
||||
const objModel = require('arsenal').models.ObjectMD;
|
||||
|
||||
function _validateTree(whereClause, possibleAttributes) {
|
||||
let invalidAttribute;
|
||||
function _searchTree(node) {
|
||||
if (!invalidAttribute) {
|
||||
// the node.table would contain userMd for instance
|
||||
// and then the column would contain x-amz-meta-whatever
|
||||
if (node.table) {
|
||||
if (!possibleAttributes[node.table]) {
|
||||
invalidAttribute = node.table;
|
||||
}
|
||||
}
|
||||
// if there is no table, the column would contain the non-nested
|
||||
// attribute (e.g., content-length)
|
||||
if (!node.table && node.column) {
|
||||
if (!possibleAttributes[node.column]) {
|
||||
invalidAttribute = node.column;
|
||||
}
|
||||
}
|
||||
// the attributes we care about are always on the left because
|
||||
// the value being searched for is on the right
|
||||
if (node.left) {
|
||||
_searchTree(node.left);
|
||||
}
|
||||
if (node.right && node.right.left) {
|
||||
_searchTree(node.right.left);
|
||||
}
|
||||
}
|
||||
}
|
||||
_searchTree(whereClause);
|
||||
return invalidAttribute;
|
||||
}
|
||||
|
||||
/**
|
||||
* validateSearchParams - validate value of ?search= in request
|
||||
* @param {string} searchParams - value of search params in request
|
||||
* which should be jsu sql where clause
|
||||
* For metadata: userMd.`x-amz-meta-color`=\"blue\"
|
||||
* For tags: tags.`x-amz-meta-color`=\"blue\"
|
||||
* For any other attribute: `content-length`=5
|
||||
* @return {undefined | error} undefined if validates or arsenal error if not
|
||||
*/
|
||||
function validateSearchParams(searchParams) {
|
||||
let ast;
|
||||
try {
|
||||
ast =
|
||||
parser.parse(`SELECT * FROM t WHERE ${searchParams}`);
|
||||
} catch (e) {
|
||||
if (e) {
|
||||
return errors.InvalidArgument
|
||||
.customizeDescription('Invalid sql where clause ' +
|
||||
'sent as search query');
|
||||
}
|
||||
}
|
||||
|
||||
const possibleAttributes = objModel.getAttributes();
|
||||
// For search we aggregate the user metadata (x-amz-meta)
|
||||
// under the userMd attribute so add to possibilities
|
||||
possibleAttributes.userMd = true;
|
||||
const invalidAttribute = _validateTree(ast.where, possibleAttributes);
|
||||
if (invalidAttribute) {
|
||||
return errors.InvalidArgument.customizeDescription('Search param ' +
|
||||
`contains unknown attribute: ${invalidAttribute}`);
|
||||
}
|
||||
return undefined;
|
||||
}
|
||||
|
||||
module.exports = validateSearchParams;
|
|
@ -1,5 +1,6 @@
|
|||
const querystring = require('querystring');
|
||||
const { errors, versioning, s3middleware } = require('arsenal');
|
||||
const stringHash = require('string-hash');
|
||||
const { errors, versioning, s3middleware, LivyClient } = require('arsenal');
|
||||
|
||||
const constants = require('../../constants');
|
||||
const services = require('../services');
|
||||
|
@ -7,11 +8,80 @@ const { metadataValidateBucket } = require('../metadata/metadataUtils');
|
|||
const collectCorsHeaders = require('../utilities/collectCorsHeaders');
|
||||
const escapeForXml = s3middleware.escapeForXml;
|
||||
const { pushMetric } = require('../utapi/utilities');
|
||||
|
||||
const validateSearchParams = require('../api/apiUtils/bucket/validateSearch');
|
||||
const versionIdUtils = versioning.VersionID;
|
||||
|
||||
// Sample XML response for GET bucket objects:
|
||||
/*
|
||||
const config = require('../Config.js').config;
|
||||
const werelogs = require('werelogs');
|
||||
werelogs.configure({ level: config.log.logLevel,
|
||||
dump: config.log.dumpLevel });
|
||||
const log = new werelogs.Logger('LivyClient');
|
||||
const useHttps = !!config.livy.transport.https;
|
||||
const MAX_ACTIVE_SESSIONS = 6;
|
||||
const livyClient = new LivyClient(config.livy.host,
|
||||
config.livy.port, log, useHttps);
|
||||
const setUpSessionCode = 'import com.scality.clueso._\n' +
|
||||
'import com.scality.clueso.query._\n' +
|
||||
'val config = com.scality.clueso.SparkUtils.' +
|
||||
'loadCluesoConfig("/clueso/conf/application.conf"); \n' +
|
||||
'val queryExecutor = MetadataQueryExecutor(spark, config); \n';
|
||||
const sessionConfig = {
|
||||
kind: 'spark',
|
||||
driverMemory: '2g',
|
||||
numExecutors: 3,
|
||||
executorMemory: '4g',
|
||||
jars: ['/clueso/lib/clueso.jar'],
|
||||
conf: {
|
||||
'spark.hadoop.fs.s3a.access.key': 'accessKey1',
|
||||
'spark.hadoop.fs.s3a.secret.key': 'verySecretKey1',
|
||||
},
|
||||
|
||||
};
|
||||
|
||||
|
||||
// parse JSON safely without throwing an exception
|
||||
function _safeJSONParse(s) {
|
||||
try {
|
||||
return JSON.parse(s);
|
||||
} catch (e) {
|
||||
return e;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* findAvailableSession - find an idle session
|
||||
* @param {Object[]} sessions - array of session objects
|
||||
* @param {String} bucketName - name of bucket being searched
|
||||
* @return {Object} availableSession
|
||||
* {number} availableSession.sessionId - sessionId to use
|
||||
* {boolean} availableSession.SlowDown - whether to return SlowDown error
|
||||
*/
|
||||
function findAvailableSession(sessions, bucketName) {
|
||||
const availableSession = {};
|
||||
const possibleSessions = [];
|
||||
const startingSessions = [];
|
||||
sessions.forEach(session => {
|
||||
if (session.state === 'idle' || sessions.state === 'busy') {
|
||||
possibleSessions.push(session);
|
||||
}
|
||||
if (session.state === 'starting') {
|
||||
startingSessions.push(session);
|
||||
}
|
||||
});
|
||||
if (possibleSessions.length > 0) {
|
||||
const sessionIndex = stringHash(bucketName) % possibleSessions.length;
|
||||
availableSession.sessionId = possibleSessions[sessionIndex].id;
|
||||
return availableSession;
|
||||
}
|
||||
if (startingSessions.length +
|
||||
possibleSessions.length >= MAX_ACTIVE_SESSIONS) {
|
||||
availableSession.SlowDown = true;
|
||||
return availableSession;
|
||||
}
|
||||
return availableSession;
|
||||
}
|
||||
|
||||
/* Sample XML response for GET bucket objects:
|
||||
<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
|
||||
<Name>example-bucket</Name>
|
||||
<Prefix></Prefix>
|
||||
|
@ -203,6 +273,99 @@ function processMasterVersions(bucketName, listParams, list) {
|
|||
return xml.join('');
|
||||
}
|
||||
|
||||
function handleStatement(sessionId, codeToExecute, corsHeaders, bucketName,
|
||||
listParams, log, callback) {
|
||||
log.info('about to postStatement with codeToExecute', { codeToExecute });
|
||||
return livyClient.postStatement(sessionId,
|
||||
codeToExecute, (err, res) => {
|
||||
if (err) {
|
||||
log.info('error from livy posting ' +
|
||||
'statement', { error: err.message });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
if (!res || !Number.isInteger(res.id)) {
|
||||
log.error('posting statement did not result ' +
|
||||
'in valid statement id', { resFromLivy: res });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
return livyClient.getStatement(sessionId, res.id, (err, res) => {
|
||||
// TODO: Need to test this!!
|
||||
if (err && err.message.includes('Path does not exist')) {
|
||||
log.info('return empty listing since livy reports ' +
|
||||
'no path for bucket', { error: err.message });
|
||||
const list = { CommonPrefixes: [], Contents: [] };
|
||||
const xml = processMasterVersions(bucketName,
|
||||
listParams, list);
|
||||
return callback(null, xml, corsHeaders);
|
||||
}
|
||||
if (err) {
|
||||
log.info('error from livy getting ' +
|
||||
'statement', { error: err.message });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
if (!res || !res.data || !res.data['text/plain']
|
||||
|| !res.status === 'ok') {
|
||||
log.error('getting statement did not result ' +
|
||||
'in valid result', { resFromLivy: res });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
const parsedRes = _safeJSONParse(res.data['text/plain']);
|
||||
if (parsedRes instanceof Error) {
|
||||
log.error('livy returned invalid json',
|
||||
{ resFromLivy: res });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
// Not grouping searched keys by common prefix so just
|
||||
// set CommonPrefixes to an empty array
|
||||
const list = { CommonPrefixes: [] };
|
||||
list.Contents = parsedRes.map(entry => {
|
||||
return {
|
||||
key: entry.key,
|
||||
value: {
|
||||
LastModified: entry['last-modified'],
|
||||
ETag: entry['content-md5'],
|
||||
Size: entry['content-length'],
|
||||
StorageClass: entry['x-amz-storage-class'],
|
||||
Owner: {
|
||||
ID: entry['owner-id'],
|
||||
DisplayName: entry['owner-display-name'],
|
||||
},
|
||||
},
|
||||
};
|
||||
});
|
||||
if (listParams.maxKeys < list.Contents.length) {
|
||||
// If received one more key than the max, the
|
||||
// last item is to send back a next marker
|
||||
// so remove from contents and send as NextMarker
|
||||
list.NextMarker = list.Contents.pop().key;
|
||||
list.isTruncated = 'true';
|
||||
}
|
||||
// TODO: (1) handle versioning,
|
||||
// (2) TEST nextMarkers -- nextMarker should be
|
||||
// the last key returned if the number of keys is more than the
|
||||
// max keys (since we request max plus 1)
|
||||
// (3) TEST sending nextMarker and max keys
|
||||
const xml = processMasterVersions(bucketName, listParams, list);
|
||||
return callback(null, xml, corsHeaders);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* bucketGet - Return list of objects in bucket
|
||||
* @param {AuthInfo} authInfo - Instance of AuthInfo class with
|
||||
|
@ -227,6 +390,12 @@ function bucketGet(authInfo, request, log, callback) {
|
|||
if (Number.isNaN(requestMaxKeys) || requestMaxKeys < 0) {
|
||||
return callback(errors.InvalidArgument);
|
||||
}
|
||||
if (params.search !== undefined) {
|
||||
const validation = validateSearchParams(params.search);
|
||||
if (validation instanceof Error) {
|
||||
return callback(validation);
|
||||
}
|
||||
}
|
||||
// AWS only returns 1000 keys even if max keys are greater.
|
||||
// Max keys stated in response xml can be greater than actual
|
||||
// keys returned.
|
||||
|
@ -259,6 +428,75 @@ function bucketGet(authInfo, request, log, callback) {
|
|||
listParams.versionIdMarker = params['version-id-marker'] ?
|
||||
versionIdUtils.decode(params['version-id-marker']) : undefined;
|
||||
}
|
||||
if (params.search !== undefined) {
|
||||
log.info('performaing search listing', { search: params.search });
|
||||
// Add escape character to quotes since enclosing where clause
|
||||
// in quotes when sending to livy
|
||||
const whereClause = params.search.replace(/"/g, '\\"');
|
||||
// spark should return keys starting AFTER marker alphabetically
|
||||
// spark should return up to maxKeys
|
||||
const start = listParams.marker ? `Some("${listParams.marker}")` :
|
||||
'None';
|
||||
const searchCodeToExecute =
|
||||
'queryExecutor.executeAndPrint(MetadataQuery' +
|
||||
`("${bucketName}", "${whereClause}", ${start}, ` +
|
||||
// Add one to the keys requested so we can use the last key
|
||||
// as a next marker if needed
|
||||
// Might just need the last one???!!!
|
||||
`${listParams.maxKeys + 1}));\n`;
|
||||
|
||||
// List sessions to find available.
|
||||
// If at least 4 active and busy/starting, return SlowDown error
|
||||
// (don't want to create too many since holding dataframes
|
||||
// in mem within a session)
|
||||
// If idle sessions, use random available one
|
||||
return livyClient.getSessions(null, null,
|
||||
(err, res) => {
|
||||
if (err || !res) {
|
||||
log.info('err from livy listing sessions',
|
||||
{ error: err });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error contacting spark ' +
|
||||
'for search'), null, corsHeaders);
|
||||
}
|
||||
const availableSession =
|
||||
findAvailableSession(res.sessions, bucketName);
|
||||
if (availableSession.SlowDown) {
|
||||
return callback(errors.SlowDown, null, corsHeaders);
|
||||
}
|
||||
if (availableSession.sessionId === undefined) {
|
||||
return livyClient.postSession(sessionConfig,
|
||||
(err, res) => {
|
||||
if (err) {
|
||||
log.info('error from livy creating session',
|
||||
{ error: err.message });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
if (!res || !Number.isInteger(res.id)) {
|
||||
log.error('posting session did not ' +
|
||||
'result in valid session id',
|
||||
{ resFromLivy: res });
|
||||
return callback(errors.InternalError
|
||||
.customizeDescription('Error ' +
|
||||
'performing search'),
|
||||
null, corsHeaders);
|
||||
}
|
||||
const codeToExecute = `${setUpSessionCode} ` +
|
||||
`${searchCodeToExecute};`;
|
||||
return handleStatement(res.id, codeToExecute,
|
||||
corsHeaders, bucketName, listParams, log,
|
||||
callback);
|
||||
});
|
||||
}
|
||||
// no need to create session
|
||||
return handleStatement(availableSession.sessionId,
|
||||
searchCodeToExecute, corsHeaders, bucketName,
|
||||
listParams, log, callback);
|
||||
});
|
||||
}
|
||||
return services.getObjectListing(bucketName, listParams, log,
|
||||
(err, list) => {
|
||||
if (err) {
|
||||
|
|
|
@ -14,6 +14,7 @@ const data = require('./data/wrapper');
|
|||
|
||||
const routes = arsenal.s3routes.routes;
|
||||
const websiteEndpoints = _config.websiteEndpoints;
|
||||
const whiteListedIps = _config.whiteListedIps;
|
||||
|
||||
let allEndpoints;
|
||||
function updateAllEndpoints() {
|
||||
|
@ -77,6 +78,7 @@ class S3Server {
|
|||
websiteEndpoints,
|
||||
blacklistedPrefixes,
|
||||
dataRetrievalFn: data.get,
|
||||
whiteListedIps,
|
||||
};
|
||||
routes(req, res, params, logger);
|
||||
}
|
||||
|
|
|
@ -19,15 +19,18 @@
|
|||
},
|
||||
"homepage": "https://github.com/scality/S3#readme",
|
||||
"dependencies": {
|
||||
"aws-sdk": "2.28.0",
|
||||
"arsenal": "scality/Arsenal",
|
||||
"arsenal": "scality/Arsenal#ft/clueso",
|
||||
"async": "~2.5.0",
|
||||
"aws-sdk": "2.28.0",
|
||||
"azure-storage": "^2.1.0",
|
||||
"bucketclient": "scality/bucketclient",
|
||||
"commander": "^2.9.0",
|
||||
"ioredis": "2.4.0",
|
||||
"node-sql-parser": "0.0.1",
|
||||
"node-uuid": "^1.4.3",
|
||||
"npm-run-all": "~4.0.2",
|
||||
"sproxydclient": "scality/sproxydclient",
|
||||
"string-hash": "^1.1.3",
|
||||
"utapi": "scality/utapi",
|
||||
"utf8": "~2.1.1",
|
||||
"vaultclient": "scality/vaultclient",
|
||||
|
|
|
@ -0,0 +1,118 @@
|
|||
const assert = require('assert');
|
||||
const { errors } = require('arsenal');
|
||||
const validateSearch =
|
||||
require('../../../lib/api/apiUtils/bucket/validateSearch');
|
||||
|
||||
|
||||
describe('validate search where clause', () => {
|
||||
const tests = [
|
||||
{
|
||||
it: 'should allow a valid simple search with table attribute',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should allow a simple search with known ' +
|
||||
'column attribute',
|
||||
searchParams: '`content-length`="10"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should allow valid search with AND',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" ' +
|
||||
'AND userMd.`x-amz-meta-age`="5"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should allow valid search with OR',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" ' +
|
||||
'OR userMd.`x-amz-meta-age`="5"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should allow valid search with double AND',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" ' +
|
||||
'AND userMd.`x-amz-meta-age`="5" ' +
|
||||
'AND userMd.`x-amz-meta-whatever`="ok"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should allow valid chained search with tables and columns',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" ' +
|
||||
'AND userMd.`x-amz-meta-age`="5" ' +
|
||||
'AND `content-length`="10"' +
|
||||
'OR isDeleteMarker="true"' +
|
||||
'AND userMd.`x-amz-meta-whatever`="ok"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should allow valid LIKE search',
|
||||
searchParams: 'userMd.`x-amz-meta-dog` LIKE "lab%" ' +
|
||||
'AND userMd.`x-amz-meta-age` LIKE "5%" ' +
|
||||
'AND `content-length`="10"',
|
||||
result: undefined,
|
||||
},
|
||||
{
|
||||
it: 'should disallow a LIKE search with invalid attribute',
|
||||
searchParams: 'userNotMd.`x-amz-meta-dog` LIKE "labrador"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: userNotMd'),
|
||||
},
|
||||
{
|
||||
it: 'should disallow a simple search with unknown attribute',
|
||||
searchParams: 'userNotMd.`x-amz-meta-dog`="labrador"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: userNotMd'),
|
||||
},
|
||||
{
|
||||
it: 'should disallow a compound search with unknown ' +
|
||||
'attribute on right',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" AND ' +
|
||||
'userNotMd.`x-amz-meta-dog`="labrador"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: userNotMd'),
|
||||
},
|
||||
{
|
||||
it: 'should disallow a compound search with unknown ' +
|
||||
'attribute on left',
|
||||
searchParams: 'userNotMd.`x-amz-meta-dog`="labrador" AND ' +
|
||||
'userMd.`x-amz-meta-dog`="labrador"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: userNotMd'),
|
||||
},
|
||||
{
|
||||
it: 'should disallow a chained search with one invalid ' +
|
||||
'table attribute',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" ' +
|
||||
'AND userMd.`x-amz-meta-age`="5" ' +
|
||||
'OR userNotMd.`x-amz-meta-whatever`="ok"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: userNotMd'),
|
||||
},
|
||||
{
|
||||
it: 'should disallow a simple search with unknown ' +
|
||||
'column attribute',
|
||||
searchParams: 'whatever="labrador"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: whatever'),
|
||||
},
|
||||
{
|
||||
it: 'should disallow a chained search with one invalid ' +
|
||||
'column attribute',
|
||||
searchParams: 'userMd.`x-amz-meta-dog`="labrador" ' +
|
||||
'AND userMd.`x-amz-meta-age`="5" ' +
|
||||
'OR madeUp="something"' +
|
||||
'OR userMd.`x-amz-meta-whatever`="ok"',
|
||||
result: errors.InvalidArgument.customizeDescription('Search ' +
|
||||
'param contains unknown attribute: madeUp'),
|
||||
},
|
||||
];
|
||||
|
||||
tests.forEach(test => {
|
||||
it(test.it, () => {
|
||||
const actualResult =
|
||||
validateSearch(test.searchParams);
|
||||
assert.deepStrictEqual(actualResult, test.result);
|
||||
});
|
||||
});
|
||||
});
|
Loading…
Reference in New Issue