master #3

antilles · 2024-02-13T14:43:52+03:00

antilles commented

2024-02-13 14:43:52 +03:00

No description provided.

antilles added 33 commits 2024-02-13 14:43:53 +03:00

Fix common realloc memory leak mistakes found by cppcheck 5d9d6f32a0

Initialize mod_revision field in etcd_state_client d00d4dbac0

Add CLA PR form 5935640a4a

Fix "partly outside array bounds" warnings for GCC 12 in cpp-btree 2cf649eba6

Fix recheck_pgs bug introduced in 1.4.0 3ca3b8a8d8

Add a test for simple master switching without PG reconfiguration 2aa5aa7ab6

Also use osd_out_time:1 only in select tests and restart mon in tests only on connection errors

Add detailed formula for theoretical EC N+K random write performance 80aac39513

Release 1.4.1 ba55f91409

- Fix a monitor crash on primary OSD switching introduced in 1.4.0
- Fix "partly outside array bounds" warnings for GCC 12 in cpp-btree
- Fix a realloc memory leak in theory possible with too large listings (OSD_OP_LIST)

Add patch for libvirt 9.10 d27524f441

Change default up_wait_retry_interval to 50 ms 1c322b33ed

Sync only completed writes 1cec62d25d

Should be a final remaining fix to EC + non-capacitor (non-immediate-commit) write hangs :).

First it was breaking non-EC ("instantly stable") writes because they sometimes
complete out of order which was leading to the following error:

terminate called after throwing an instance of 'std::runtime_error'
  what():  BUG: Unexpected dirty_entry 1000000000001:29480000 v65540 unstable state during flush: 0x151

But it is easily fixed by scanning previous and next dirty_entries in mark_stable.

Fix flapping "scrub" test cc76e6876b

Change default etcd_mon_ttl d2b43cb118

Fix invalid parsing of autosync_writes in blockstore leading to autosyncs after every operation with disabled immediate_commit :D a86a380d20

Sync after sending all deletes to each PG in cli rm-data cb9c30bc31

Fix OSD space reporting sometimes adding garbage zeros for deleted inodes (causing extra pool/stats etcd keys for deleted pools) f03a9db4d9

Mark secondary OSDs with deletions as dirty to not forget to sync & autosync them 581d02e581

In fact, do not autosync blockstore when autosync_writes=0 77c10fd1f8

Log to systemd by default e026de95d5

Release 1.4.2 016115c0d4

- Log to systemd by default
- Fix excessive autosyncs after every operation with disabled immediate_commit (introduced in 1.1.0)
- Fix a possible write stall with EC due to the lack of OSD wakeup after stabilizing previous writes
- Change sync operation semantics as a final fix to possible write stalls with EC and disabled immediate_commit
- Sync after deleting data in CLI rm / rm-data if immediate_commit is disabled
- Fix OSDs ignoring syncs & autosyncs for delete operations
- Fix OSD space reporting sometimes adding garbage zeros for deleted inodes (causing extra pool/stats etcd keys for deleted pools)
- Speed up monitor failover - change default etcd_mon_ttl from 30 to 5 seconds
- Speed up operation retries - change default up_wait_retry_interval to 50 ms
- Add patch for libvirt 9.10

Followup to 1.4.2 write stall fix - sadly, the previous version was not working correctly :) 5d3317e4f2

Ignore down OSDs in monitor statistics aggregation 8e25a28a08

Release 1.4.3 27e9f244ec

Hotfix for hotfix O:-)

- "Write stall fix" was incomplete and EC write stalls could
  continue even on 1.4.2. Now they're finally fixed O:-)
- Make monitor ignore statistics of stopped OSDs. Previously if you stopped all
  OSDs the last total I/O numbers would remain the same indefinitely

Add a test for EC segfault with partial overwrite in 1234 -> 5030 rebalance scenario c53357ac45

Fix that EC segfault (1234 -> 5030 partial overwrite) e7ac855b07

Print etcd dbSize instead of dbSizeInUse in status 1e3c4edea0

Fix flusher sometimes being unable to trim journal when the flush queue is empty 38ba76e893

Fix dynamic journal space reservation: include the new write itself, too ca34a6047a

Add a FIXME about incomplete PGs b127da40f7

Add cutoff threshold for recovery auto-tuning bb2f395f1e

Apply recovery pause before writes, after commits, and do not apply it to syncs to not block EC pools from functioning 978bdc128a

Raise test_snapshot_chain_ec timeout to 6 minutes 2947ea93e8

Release 1.4.4 c777a0041a

A couple of fixes for EC pools

- Fix a segfault possible on partial EC overwrite in 1234 -> 5030 rebalance scenario
- Fix two problems leading to EC pools stalling on rebalance & parallel sudden stops
  of OSDs, for example during a sudden poweroff of a host:
  - Recovery auto-tuning (1.4.0 feature) could apply too large delays and stall
    the EC journal - fixed by limiting delays with a new recovery_tune_sleep_cutoff_us
    parameter (10 seconds by default) and applying recovery pauses before write
    operations, not after them, to not occupy space in the journal for long time
  - Dynamic journal space reservation (1.3.0 feature) wasn't accounting new writes
    when checking the limit so OSDs could still fill the journal fully and stall -
    fixed by including new writes into the limit
- Print etcd dbSize instead of dbSizeInUse in status

antilles merged commit 7fea69ff5f into master

2024-02-13 14:44:09 +03:00

antilles referenced this issue from a commit

2024-02-13 14:44:10 +03:00

Merge pull request 'master' (#3) from vitalif/vitastor:master into master

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: antilles/vitastor#3

Allow edits from maintainers