functional: rename to "listCases"

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
release-3.4
Gyuho Lee 2018-04-11 19:35:17 -07:00
parent d275437c05
commit 23ce3a1acc
3 changed files with 9 additions and 9 deletions

View File

@ -263,12 +263,12 @@ func (clus *Cluster) updateCases() {
}
}
func (clus *Cluster) failureStrings() (fs []string) {
fs = make([]string, len(clus.cases))
func (clus *Cluster) listCases() (css []string) {
css = make([]string, len(clus.cases))
for i := range clus.cases {
fs[i] = clus.cases[i].Desc()
css[i] = clus.cases[i].Desc()
}
return fs
return css
}
// UpdateDelayLatencyMs updates delay latency with random value

View File

@ -126,7 +126,7 @@ func (clus *Cluster) doRound() error {
zap.Int("round", clus.rd),
zap.Int("case", clus.cs),
zap.Int("case-total", len(clus.cases)),
zap.Strings("failures", clus.failureStrings()),
zap.Strings("cases", clus.listCases()),
)
for i, fa := range clus.cases {
clus.cs = i
@ -260,7 +260,7 @@ func (clus *Cluster) doRound() error {
clus.lg.Info(
"round ALL PASS",
zap.Int("round", clus.rd),
zap.Strings("failures", clus.failureStrings()),
zap.Strings("cases", clus.listCases()),
zap.Int("case-total", len(clus.cases)),
zap.Duration("took", time.Since(roundNow)),
)

View File

@ -260,16 +260,16 @@ func Test_read(t *testing.T) {
cfg.lg = logger
cfg.updateCases()
fs1 := cfg.failureStrings()
fs1 := cfg.listCases()
cfg.shuffleCases()
fs2 := cfg.failureStrings()
fs2 := cfg.listCases()
if reflect.DeepEqual(fs1, fs2) {
t.Fatalf("expected shuffled failure cases, got %q", fs2)
}
cfg.shuffleCases()
fs3 := cfg.failureStrings()
fs3 := cfg.listCases()
if reflect.DeepEqual(fs2, fs3) {
t.Fatalf("expected reshuffled failure cases from %q, got %q", fs2, fs3)
}