099952136a
Merge pull request #8107 from heyitsanthony/lock-faster
...
concurrency: fetch current lock holder when creating waitlist key
2017-06-15 15:12:08 -07:00
037e33e833
Merge pull request #8093 from gyuho/grafana
...
Documentation/op-guide: fix failed RPC rate, leader election metrics
2017-06-15 11:59:03 -07:00
1748fe3eda
Documentation/op-guide: fix failed RPC rate, leader election metrics
...
This fixes failed RPC rate query, where we do not need
subtraction because we already query by the status code.
Also adds grpc_method to make it more specific. Most of the
time, the failure recovers within 10-second, which is our
Prometheus scrap interval, so 'rate' query might not cover
that time window, showing as 0s, but still shows up in the graph.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-15 11:54:18 -07:00
f5b96991a1
concurrency: fetch current lock holder when creating waitlist key
...
The uncontended path for a mutex would fetch the minimum
revision key on the prefix after creating its entry in
the wait list. This fetch can be rolled into the txn for
creating the wait key, eliminating a round-trip for immediately
acquiring the lock.
2017-06-15 11:29:34 -07:00
1f206c027a
Merge pull request #8106 from heyitsanthony/clarify-watch-comment
...
clientv3: clarify Watch close conditions
2017-06-15 10:56:25 -07:00
3a37b68cda
Merge pull request #8105 from nkovacs/its
...
Documentation: grammar fixes, it's -> its
2017-06-15 10:46:20 -07:00
13d9438cf9
clientv3: clarify Watch close conditions
...
The "too slow" comment is rather vague. If the server closes
the watch for being too slow (it doesn't seem to any more), the
watch client should gracefully resume instead of forcing the
user to handle it.
Also removed the 'opts' comment since it wasn't being maintained.
2017-06-15 09:34:00 -07:00
66687da3ba
*: grammar fixes, it's -> its
2017-06-15 18:23:16 +02:00
ee0c805de2
Merge pull request #8099 from gyuho/rate-limit-lease-expiration
...
lease: rate limit revoke runLoop
2017-06-14 15:39:58 -07:00
0011b78bd5
lease: rate limit revoke runLoop
...
Fix https://github.com/coreos/etcd/issues/8097 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-14 14:22:16 -07:00
e6d26675e6
Merge pull request #8090 from glevand/for-merge-aci
...
build-aci: Fix ACI image name
2017-06-14 08:41:58 -07:00
e402606f02
build-aci: Fix ACI image name
...
The appc discovery spec states that the architecture specifier in the ACI
image file name will be an ACI architecture value. Our build scripts were
using GOARCH in the image name, which is incorrect for arm64/aarch64.
See: https://github.com/appc/spec/blob/master/spec/discovery.md
Fixes errors like these on arm64 machines:
$ rkt --debug --insecure-options=image fetch coreos.com/etcd:v3.2.0-rc.1
image: remote fetching from URL "https://github.com/coreos/etcd/releases/download/v3.2.0-rc.1/etcd-v3.2.0-rc.1-linux-aarch64.aci "
fetch: bad HTTP status code: 404
Signed-off-by: Geoff Levand <geoff@infradead.org>
2017-06-13 13:09:02 -07:00
750dc7f157
Merge pull request #8088 from jbowens/snap-example
...
contrib/raftexample: save snapshot to WAL first
2017-06-13 12:44:13 -07:00
74e020b715
contrib/raftexample: save snapshot to WAL first
...
Save the snapshot index to the WAL before saving the snapshot to the
filesystem. This ensures that we'll only ever call wal.Open with a
snapshot that was previously saved to the WAL.
2017-06-13 11:24:07 -07:00
3993f37a26
Merge pull request #8081 from WIZARD-CXY/master
...
Documentation: alert.rules. fix labels bug
2017-06-13 10:56:04 -07:00
e006e2dbcb
Merge pull request #8087 from gyuho/bom
...
bill-of-materials: regenerate with multi licenses
2017-06-13 10:46:06 -07:00
a7c33d48de
bill-of-materials: regenerate with multi licenses
...
Fix https://github.com/coreos/etcd/issues/8086 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-13 10:25:29 -07:00
4445996a38
Merge pull request #8084 from heyitsanthony/update-protobuf
...
vendor: update github.com/{gogo,golang}/protobuf
2017-06-12 19:09:49 -07:00
5ae04259c4
Documentation: alert.rules. fix labels bug
2017-06-13 09:33:13 +08:00
b7741c6ecf
Merge pull request #8083 from heyitsanthony/initial-cluster-warning
...
etcdserver: better warning when initial-cluster doesn't match advertise urls
2017-06-12 15:15:08 -07:00
4ebeba0e18
*: regen protofiles with latest protobuf tools
2017-06-12 15:14:43 -07:00
2afd0a726f
vendor: update github.com/gogo/protobuf and github.com/golang/protobuf
2017-06-12 14:26:15 -07:00
7ff5b05004
etcdserver: better warning when initial-cluster doesn't match advertise urls
...
The old error was not clear about what URLs needed to be added, sometimes
truncating the list. To make it clearer, print out the missing entries
for --initial-cluster and print the full list of initial advertise peers.
Fixes #8079 and #7927
2017-06-12 14:14:16 -07:00
933aa09b73
Merge pull request #8070 from heyitsanthony/etcdctl-cluster-health
...
ctlv2: report unhealthy in cluster-health if any node is unavailable
2017-06-09 14:57:03 -07:00
3fcb8336aa
e2e: update cluster-health test for new etcdctl output
2017-06-09 13:55:16 -07:00
b194276289
Merge pull request #8075 from gyuho/upgrade-doc
...
Documentation/upgrades: link to previous guides
2017-06-09 13:02:57 -07:00
7f3127441b
Documentation/upgrades: link to previous guides
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-09 12:33:39 -07:00
3a6180d490
Merge pull request #8072 from heyitsanthony/auth-proxy-test
...
integration: test auth layer in grpc proxy tests
2017-06-09 11:32:27 -07:00
bdddbcc414
Merge pull request #8074 from heyitsanthony/no-limit-snapshot
...
rafthttp: permit very large v2 snapshots
2017-06-09 11:12:25 -07:00
84e6aaff66
Merge pull request #7995 from gyuho/NEWS
...
NEWS: add v3.2.0
2017-06-09 11:08:29 -07:00
d5b917daad
Merge pull request #8069 from heyitsanthony/fix-watch-bench
...
benchmark: refactor watch benchmark
2017-06-09 11:04:20 -07:00
ad0b3cfdab
ctlv2: report unhealthy in cluster-health if any node is unavailable
...
Fixes #8061 and #7032
2017-06-09 10:57:17 -07:00
9543431aeb
rafthttp: permit very large v2 snapshots
...
v2 snapshots were hitting the 512MB message decode limit, causing
sending snapshots to new members to fail for being too big.
2017-06-09 10:41:27 -07:00
d6750158fb
NEWS: add v3.2.0
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-09 10:37:27 -07:00
56841bbc5f
Merge pull request #8071 from heyitsanthony/txn-rev
...
etcdserver: use same ReadView for read-only txns
2017-06-09 09:43:18 -07:00
798119ed6f
integration: test auth layer in grpcproxy tests
2017-06-09 09:36:16 -07:00
5bb0a091fc
adapter: auth server to client adapter
2017-06-09 09:36:16 -07:00
d173b09a1b
etcdserver: use same ReadView for read-only txns
...
A read-only txn isn't serialized by raft, but it uses a fresh
read txn for every mvcc access prior to executing its request ops.
If a write txn modifies the keys matching the read txn's comparisons,
the read txn may return inconsistent results.
To fix, use the same read-only mvcc txn for the duration of the etcd
txn. Probably gets a modest txn speedup as well since there are
fewer read txn allocations.
2017-06-09 09:20:38 -07:00
da48f1feaf
mvcc: create TxnWrites from TxnRead with NewReadOnlyTxnWrite
...
Already used internally by mvcc, but needed by etcdserver txns.
2017-06-09 09:20:38 -07:00
ad22aaa354
integration: test txn comparison and concurrent put ordering
2017-06-09 09:20:38 -07:00
3b460506d9
Merge pull request #8067 from gyuho/docker-doc
...
Documentation/op-guide: do not use host network, fix indentation
2017-06-09 09:14:00 -07:00
56db7e56f9
benchmark: refactor watch benchmark
2017-06-08 21:14:08 -07:00
a8c073c51e
Merge pull request #8066 from fanminshi/keepAlive_Close_to_close
...
clientv3: change Close() to close() for keepAlive and watchGrpcStream
2017-06-08 14:59:24 -07:00
762b2c625c
clientv3: change watchGrpcStream Close() to close()
...
private struct shouldn't have public method.
2017-06-08 12:11:06 -07:00
74a2b2e873
Documentation/op-guide: do not use host network, fix indentation
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-08 12:09:12 -07:00
2caae60004
Merge pull request #8062 from heyitsanthony/revert-v2machines
...
v2http: put back /v2/machines and mark as non-deprecated
2017-06-08 12:01:58 -07:00
4dff7aaa2a
clientv3: change keepAlive Close() to close()
...
keepAlive is a private struct that belongs to clientv3 pkg and shouldn't expose a public Close() method.
2017-06-08 11:53:59 -07:00
9ffdb3a59e
Merge pull request #8064 from gyuho/lease-expiration-metrics
...
etcdserver: add leaseExpired metrics
2017-06-08 11:13:52 -07:00
300feea177
Merge pull request #8052 from heyitsanthony/watch-victim-test
...
mvcc: test watch victim/delay path
2017-06-08 11:10:33 -07:00
45fd8279f0
etcdserver: add leaseExpired debugging metrics
...
Fix https://github.com/coreos/etcd/issues/8050 .
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-06-08 10:36:25 -07:00
Anthony Romano