f4141f0f51
raft: handle 'MsgTransferLeader' in follower
2016-08-10 16:24:29 -07:00
5f0c122496
raft: fix getting unapplied log entries
2016-08-08 10:44:02 -07:00
6c3efde51b
Merge pull request #6099 from sinsharat/master
...
raft: handling of applying old snapshots
2016-08-05 07:38:07 -07:00
c46955b60a
Merge pull request #6097 from swingbach/master
...
raft: fix #6096
2016-08-04 11:40:02 -07:00
fd757756f5
raft: handling of applying old snapshots
...
There was a TODO requirement to handle ErrorSnapshotOutOfDate for the
function ApplySnapshot. The same has been implemented
#6090
2016-08-04 21:08:24 +05:30
41dee84733
raft: fix #6096
2016-08-04 18:31:22 +08:00
6e7baab32c
Merge pull request #6070 from swingbach/master
...
raft: fix #6068
2016-08-03 19:59:07 -07:00
c0a8da7fd0
raft: minor refactor
2016-08-02 08:46:43 +08:00
8d12017fe2
raft: better doc
2016-07-30 21:11:37 -07:00
992f628e6e
raft: fix #6068
2016-07-30 03:27:29 +08:00
982e18d80b
*: regenerate proto with latest grpc-gateway
2016-07-27 13:21:03 -07:00
a75688bd17
Merge pull request #6039 from xiang90/fix_r
...
raft: hide Campaign rules on applying all entries
2016-07-26 20:52:09 -07:00
0d6c028aa2
Merge pull request #6032 from xiang90/gateway
...
fix a few issues in grpc gateway
2016-07-25 16:48:38 -07:00
484f579905
raft: hide Campaign rules on applying all entries
2016-07-25 15:53:39 -07:00
fffa484a9f
*: regenerate proto for adding deleterange
2016-07-23 16:17:44 -07:00
4ff6c72257
raft: replace 'reflect.DeepEqual' with bytes.Equal
2016-07-22 16:34:13 -07:00
1c5754f02d
raft: fix readindex
2016-07-19 15:00:58 -07:00
50be793f09
*: regenerate proto
2016-07-18 09:33:32 -07:00
5b92e17e86
*: regenerate proto files
2016-07-15 13:24:19 -07:00
7432e9fbe9
Merge pull request #5809 from swingbach/master
...
raft: make leader transferring workable when quorum check is on
2016-07-12 09:46:18 -07:00
b2c1112288
Merge pull request #5921 from xiang90/r
...
raft: do not change RecentActive when resetState for progress
2016-07-12 06:54:14 -07:00
c36a40ca15
raft: introduce top-level context in message struct
2016-07-12 16:14:06 +08:00
eb08f2274e
raft: do not change RecentActive when resetState for progress
2016-07-11 21:12:14 -07:00
6f3a40cb53
raft: set leader id in stepFollower
...
Follower has already set its leader ID from
previous append messages from the leader, but
to be consistent, this adds a line to set its
leader id from leader snapshot message.
2016-07-11 16:37:31 -07:00
0d9b6ba0ab
raft: fix a few problems
2016-07-11 14:59:53 +08:00
c396b6aaaa
raft: remove unnecessary type-cast, else-clause
2016-07-09 22:01:19 -07:00
90889ebc0f
raftpb: atomic access alignment
...
The Entry struct has misaligned fields that are accessed atomically. The
misalignment is caused by the EntryType enum which the Protocol Buffers
spec forces to be a 32bit int.
Moving the order of the fields without renumbering them in the .proto file
seems to align the go structure without changing the wire format.
2016-07-08 11:13:53 -07:00
df94f58462
raft: atomic access alignment
...
The relevant structures are properly aligned, however, there is no comment
highlighting the need to keep it aligned as is present elsewhere in the
codebase.
Adding note to keep alignment, in line with similar comments in the codebase.
2016-07-08 11:05:41 -07:00
9e0de02fde
raft: fix minor grammar, remove TODO
...
- test 'Term' panic cases (remove TODO)
- fix minor grammar in 'Node' godoc
2016-07-05 07:21:52 -07:00
881a120453
raft: minor updates and clean up in log.go
...
- remove redundant test case in log_test.go
- fix test case comment ('equal or larger')
- lastnewi after matching index and term
2016-07-04 16:52:17 -07:00
8d99a666f9
Merge pull request #5854 from xiang90/r_f
...
raft: add features section to readme file
2016-07-03 18:00:31 -07:00
c76dcc5190
raft: add features section to readme file
2016-07-03 17:59:59 -07:00
9b5e99efe0
raft: remove unnecessary reflect.DeepEqual in test
2016-07-03 13:42:26 -07:00
40c4a7894d
*: support return prev deleted kv
2016-07-01 14:01:48 -07:00
2cc2372165
raft: give correct offset in unstable test
...
`unstable.entries[i] has raft log position i+unstable.offset`
So, this fixes some test cases by giving them correct
offsets.
2016-06-29 12:29:36 -07:00
e020b2a228
raft: make leader transferring workable when quorum check is on
2016-06-29 18:24:58 +08:00
df31eab136
raft: simplify truncateAndAppend
...
truncateAndAppend no need the value of 'after' with subbing one
2016-06-28 18:53:12 -07:00
5f1c763993
Merge pull request #5553 from swingbach/master
...
raft: implemented read-only query when quorum check is on
2016-06-28 12:47:43 -07:00
0faae33ace
raft: implemented read-only query when quorum check is on
2016-06-28 10:52:53 +08:00
6a48961895
raft: len(entries) before Lock, use firstIndex
...
- To avoid unnecessary locking in case len(entries) == 0
- use firstIndex method
2016-06-24 23:50:00 -07:00
33f7e7583b
raft: fix comment,method name to needSnapshotAbort
...
And 'maybeSnapshotAbort' does not 'unset'
the pendingSnapshot. 'resetState', which is called after this
metho, is the one that unsets pendingSnapshot. So this changes
the method name.
2016-06-24 07:54:10 -07:00
848f539536
raft: make tick unblock and fix potential live lock
2016-06-16 08:01:06 -07:00
5a7b7f7595
main: add grpc-gateway support
...
Now etcd can serve HTTP json request at /v3alpha/
2016-06-14 17:09:06 -07:00
ab65d2b848
raft: add docker/swarmkit as notable raft users
2016-06-09 10:10:44 -07:00
1610391449
*: following changes for proto update
2016-06-07 13:33:03 -07:00
843c53192a
raft: small fix in doc
...
'MsgBeat' is an internal type to signal the leader, not the message type
that gets sent to its followers. 'MsgHeartbeat' is the type sent to followers.
2016-06-05 17:47:46 -07:00
500296d0fb
raft: fix TestNodeStepUnblock
...
The test cases have side-effect. We need to stop testing if one of the test
fails. Also timeout should be much longer to avoid false-positive.
2016-06-03 10:22:11 -07:00
9fee7732f6
Merge pull request #5468 from swingbach/master
...
implemented leader lease when quorum check is on.
2016-06-01 16:10:41 -07:00
337ef64ed5
raft: implemented leader lease when quorum check is on
2016-06-02 06:17:27 +08:00
5b2e130f09
raft: initial readme
2016-05-28 18:37:21 -07:00
ff9d16a2e0
raft: fix tiny mistake of message type
2016-05-20 14:04:08 +08:00
1e54117580
raft: add more comments for dueling candidates test case
2016-05-19 13:51:20 +08:00
c703ccab63
raft: add more assertions for dueling candidates test case
2016-05-19 13:50:14 +08:00
910781ef5b
raft: do not panic when removing all the nodes from cluster
2016-05-16 10:04:17 -07:00
4d2424210f
Merge pull request #5313 from xiang90/fix_raft_abort
...
raft: simplify leadership transfer
2016-05-13 09:26:01 -07:00
fe884f8209
raft: update LICENSE header
2016-05-12 20:49:15 -07:00
82a6de8b69
raft: simplify leadership transfer
2016-05-10 20:03:42 -07:00
015acabdbb
*: rerun genproto -g
2016-05-02 23:02:31 -07:00
2fa5b913fe
raft: fix flaky test
...
We recently changed the randomized election timeout from (et, 2*et-1] tp
[et, 2*et-2], where et is user set election timeout.
So 2*et might trigger two elections instead of one. We need to fix the test
code accordingly.
Thanks for Tikv guys for finding this issue. We probably need to randomize
etcd/raft test more.
2016-05-02 21:08:19 -07:00
b7ac758969
*: rename storage package to mvcc
2016-04-25 15:25:51 -07:00
4b31acf0e0
*: update generated Proto
2016-04-25 14:08:33 -07:00
59c5110b73
raft: fix detected race in node.go
2016-04-22 15:45:33 -07:00
a9cfbd5414
raft/doc.go: add missing }
2016-04-19 04:21:33 -05:00
7a2ef3eb00
*: regenerate proto buffers
2016-04-13 16:24:07 -07:00
1044fbce2c
etcdctlv3: update aunto generated files
2016-04-12 22:48:47 +08:00
3a695a82a3
Merge pull request #5036 from xiang90/r_t
...
raft: add a test case for Test Slice
2016-04-11 16:02:13 -07:00
9423125ce1
raft: add a test case for Test Slice
2016-04-11 10:04:03 -07:00
9108af9046
*: clean up from go vet, misspell
2016-04-10 23:16:56 -07:00
4997ed36b4
Merge pull request #5011 from xiang90/r_c
...
raft: fix issues reported by golint
2016-04-08 11:46:12 -07:00
ac059eb8cb
raft: transfer leader feature
2016-04-08 16:56:32 +08:00
1b41ee9c99
raft: fix issues reported by golint
2016-04-07 22:14:56 -07:00
dc17eaace7
*: rename Lease Create to Grant
...
Creating a lease through the client API interface union looked like
"c.Create(...)"-- the method name wasn't very descriptive.
2016-04-07 12:28:14 -07:00
6e6d64fb9b
*: clean up unused vars, functions
...
With help from https://github.com/dominikh/go-unused .
IsNetTimeoutError seems useful, so moved to pkg/netutil.
2016-04-06 21:33:55 -07:00
68db18667a
raft: correct doc comment
2016-04-06 08:43:42 -04:00
5250784b09
raft: use rand.Intn instead of rand.Int and mod
...
This provides a better random distribution and is easier to read.
2016-04-06 08:43:42 -04:00
c09f23c46d
*: clean up bool comparison
2016-04-02 18:27:54 -07:00
5d431b4782
raft: lower split vote rate
2016-04-01 12:11:03 -07:00
bd832e5b0a
*: migrate Godeps to vendor/
2016-03-22 17:10:28 -07:00
f5e60c0e18
raft: add optimization notes
2016-03-17 09:53:50 -07:00
aa59e7518e
raft: remove unnecessary waitSchedule in test
2016-03-09 09:18:49 -08:00
aedf2c5876
raft: Config: comment wrapping @ 80col
2016-03-01 09:54:58 +01:00
6c1b3a71db
raft: clarify Heartbeat/ElectionTick comments
...
Avoid other, ambiguous interpretations.
2016-03-01 09:52:14 +01:00
afa0368dcc
*: fix godoc bugs in interfaces and slice fields
...
detected with goword
2016-02-24 00:45:40 -08:00
c5b51946eb
*: exported godoc fixups
2016-02-21 20:36:44 -08:00
390a4518c0
raft: rework comment for advance interface
2016-02-12 13:43:51 -08:00
20461ab11a
*: fix many typos
2016-01-31 21:42:39 -08:00
c827c7432c
raft: fix leaky goroutines in raft test
2016-01-31 12:41:33 -08:00
71c2a9bb3c
*: fix minor typos, comments
2016-01-30 18:15:56 -08:00
edd823bba6
raft: fix var name in comment
2016-01-29 16:18:47 +09:00
37290820de
Merge pull request #4293 from bdarnell/bcast-after-commit
...
raft: Always call bcastAppend after maybeCommit
2016-01-27 09:58:22 -08:00
be21d90108
raft/doc: add notice about thread safety of messages
...
Fixes #4285
2016-01-27 20:18:19 +11:00
6054748181
Merge pull request #4297 from ngaut/ngaut/raft-typo
...
raft: typo
2016-01-26 20:48:53 -08:00
751ab40f44
raft: typo
2016-01-27 12:35:14 +08:00
a35d5889f6
*: update gRPC, proto interface
2016-01-26 17:41:39 -08:00
0771d713e6
raft: Always call bcastAppend after maybeCommit
2016-01-26 16:55:47 -05:00
22925a1d2f
raft: Remove redundant `raft.Commit` field.
...
Keeping this field in sync with `raft.raftLog.committed` was
error-prone, so instead we synthesize the `HardState` on demand.
Fixes #4278 .
2016-01-26 15:18:55 -05:00
8199147cf8
Merge pull request #4246 from bdarnell/commit-after-remove-node
...
raft: Call maybeCommit after removing a node
2016-01-25 11:47:56 +08:00
896719c877
raft: use configured logger in raft/node.go
...
Those three log statements in node.go have not been using the logger that was passed via `raft.Config`, but instead the default raft logger. This changes it to use the proper logger.
2016-01-25 00:15:44 +11:00
53d6aede82
Merge pull request #3889 from gyuho/raft_doc.go_20151118
...
raft: doc, debugging instruction on MessageType
2016-01-22 14:22:49 -08:00
46bb2582fe
raft: Call maybeCommit after removing a node.
...
removeNode reduces the required quorum size, so some pending entries may
be able to commit after it is applied.
Discovered in cockroachdb/cockroach#3642
2016-01-20 11:05:48 -04:00
c185bdaf95
raft: Improve formatting of DescribeMessage
2016-01-20 11:03:07 -04:00
194607812c
raft: follow golint notice to replace +=1 with ++
2016-01-13 09:39:00 +08:00
eab052d5c4
Merge pull request #4141 from ngaut/ngaut/refactor
...
raft: Rename q() to quorum() which is more readable
2016-01-06 07:32:39 -08:00
54a45ba2f5
*: fix typo
2016-01-06 16:17:02 +08:00
8ee232d4ec
raft: Rename q() to quorum() which is more readable
2016-01-06 15:23:35 +08:00
b38dfda1c9
raft: Tiny refactor
...
Rename i to id since i looks like index which is confusing.
2016-01-04 21:20:54 +08:00
acee23112a
raft: typo
2016-01-04 11:51:51 +08:00
5c65c393a5
raft: small typo fixes in raft package doc
2015-12-23 16:37:06 +01:00
c72e4ae112
raft: add raftexample to the docs
...
To help people wanting use this package get started point to the
raftexample package.
2015-12-22 12:04:39 -08:00
9b2da76796
raft: remove go vet compliants
2015-12-16 13:29:23 +09:00
8696a1509c
raft/rafttest: fix shadowed variable
2015-12-12 09:38:26 -08:00
af9f352fe3
raft: update RecentActive name in comments
...
Noticed when retrospectively reviewing #3976 that a couple of places
were missed when the variable was renamed.
2015-12-11 15:06:11 -08:00
cc6d98bf89
etcdserver: only send snapshot when the member is active
2015-12-10 16:15:26 -08:00
9df46f9d6f
raft: expose RecentActive in Progress
2015-12-10 12:17:18 -08:00
1901a4c718
raft: Ensure that Progress is not nil when a MsgSnapStatus comes in.
...
This was causing some issues in cockroach cockroachdb/cockroach#2950
2015-12-07 16:01:18 -05:00
d817f885db
raft: doc, debugging instruction on MessageType
...
This adds documentation on MessageType. Having clear explanation about
MessageType helps understand raft logic and debug etcd when there is a
message dropping. This is partially for coreos#3806.
2015-12-03 00:45:11 -08:00
5bc56786dc
raft: add RawNode which is a thread-unsafe node without goroutine and remove MultiNode
2015-11-26 17:14:14 +08:00
a8cc1570d0
raft: support quorum check when raft is leader
...
If quorum check fails, the leader will step down to follower.
2015-11-24 09:36:37 -08:00
81229dbea9
*: add missing package descriptions
...
This adds and updates package descriptions in etcd projects.
And also deletes some duplicate LICENSE statements.
2015-11-17 20:54:10 -08:00
e1c108e604
raft: minor typo in progress.go
...
Fixes a minor typo.
2015-11-17 14:21:35 -08:00
5d0268aa2e
Merge pull request #3877 from bdarnell/campaign-while-leader
...
raft: no-op instead of panic for Campaigning while leader
2015-11-16 19:59:34 -08:00
fbeb58d265
raft: no-op instead of panic for Campaigning while leader
...
We need to be able to force an election (on one node) after creating a
new group (cockroachdb/cockroach#1384 ), but it is difficult to ensure
that our call to Campaign does not race with an election that may be
started by raft itself. A redundant call to Campaign should be a no-op
instead of a panic. (But the panic in becomeCandidate remains, because
we don't want to update the term or change the committed index in this
case)
2015-11-16 21:44:14 -05:00
3a65442d7d
raft: fix print format for term in one log line
...
`term` should be printed in decimal representation instead of
hexadecimal one.
2015-11-15 20:26:16 -08:00
2990249c1d
Merge pull request #3856 from xiang90/raft_doc_restart
...
raft: add doc to make restart clear
2015-11-11 11:15:49 -08:00
f7f28b9984
raft: add doc to make restart clear, especially for configuration changed case
2015-11-11 11:11:58 -08:00
6df52614fc
raft: add more words about raft protocol
2015-11-11 09:20:25 -08:00
0de52414cd
raft: extend wait timeout in TestNodeAdvance
...
This fixes the failure met in semaphore CI.
2015-11-03 16:57:18 -08:00
bf3057e5bd
raft: extend wait timeout in TestMultiNodeAdvance
...
This fixes the failure met in semaphore CI:
```
--- FAIL: TestMultiNodeAdvance-2 (0.01s)
multinode_test.go:458: expect Ready after Advance, but there is
no Ready available
```
2015-10-23 12:08:24 -07:00
01806c3e80
raft: fix malformed example name
...
It is reported by latest govet:
```
gopath/src/github.com/coreos/etcd/raft/example_test.go:26: Example_Node
has malformed example suffix: Node
```
2015-10-20 16:40:01 -07:00
1716d5858f
raft/documentation: clarify progress's subjects.
...
If I understand correctly, `progress` represents the states of follower. For
me, some comments weren't clear because it was missing the subjects of
`progress`. This adds more clarification on who is doing what. Please let me
know if I misunderstood anything. Thanks,
2015-10-15 19:15:08 -07:00
362df8e470
raft/doc: fix misuse of `for' loop in docs
2015-10-15 11:13:30 -05:00
f1f92f0fa3
raft/doc: fix typos
2015-10-15 02:17:34 -05:00
ebd8cb04c1
raft: fix a description of MemoryStorage.Compact
...
The parameter name is compactIndex, not i.
2015-10-06 21:49:33 -07:00
b2edf1d24a
raft: fix typo in doc
2015-10-01 11:21:23 -05:00
533e728b64
Merge pull request #3609 from yichengq/raft-snapshot
...
raft: kill TODO about behavior when snapshot fails
2015-09-29 19:32:31 -07:00
4c82b481a5
raft: improve behavior when snapshot fails
...
etcd is going to support incremental snapshot, and we design to let it
send at most one snapshot out at first stage. So when one snapshot is in
flight, snapshot request will return error.
When failing to get snapshot when sending MsgSnap, raft prints out
related log and abort sending this message.
2015-09-29 19:15:15 -07:00
f602767e50
raft: remove an obsolete TODO comment on 4MB maxMsgSize hard coding
...
The TODO comment was added by 7571b2cdd9b5b56c
2015-09-28 21:31:12 -07:00
b9f22cb69b
raft: fix Node doc typo
2015-09-21 06:13:33 +02:00
b7baaa6bc8
raft: Allow per-group nodeIDs in MultiNode.
...
This feature is motivated by
https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/replica_tombstone.md
which requires a change to the way CockroachDB constructs its node IDs.
2015-09-18 15:36:36 -04:00
7848ac3979
*: add missing license headers
2015-09-15 14:09:01 -07:00
68d4ec3e13
raft: improve panic error message
...
Give a human being some insight into how we might have gotten to this
state based on feedback from #3504 .
2015-09-12 12:17:02 -07:00
b2f4a5f587
*: fix spelling issues (codespell).
...
Signed-off-by: Dmitry Smirnov <onlyjob@member.fsf.org>
2015-09-11 10:22:29 +10:00
ef7cf058a2
*: update gogoproto
2015-09-03 15:32:25 -07:00
45390b9fb8
*: regenerate proto to use local import path
...
Using Go-style import paths in protos is not idiomatic. Normally, this
detail would be internal to etcd, but the path from which gogoproto
is imported affects downstream consumers (e.g. cockroachdb).
In cockroach, we want to avoid including `$GOPATH/src` in our protoc
include path for various reasons. This patch puts etcd on the same
convention, which allows this for cockroach.
More information: https://github.com/cockroachdb/cockroach/pull/2339#discussion_r38663417
This commit also regenerates all the protos, which seem to have
drifted a tiny bit.
2015-09-03 13:38:28 -04:00
4f20e01f60
raft: Ignore proposals if not a current member.
...
Fixes another panic in MultiNode.Propose.
2015-08-31 20:31:14 -04:00
6cbaaa715c
Merge pull request #3396 from bdarnell/multinode-propose-panic
...
raft: Fix a nil-pointer panic in MultiNode.Propose.
2015-08-28 12:34:49 -07:00
05924b330a
raft: Fix a nil-pointer panic in MultiNode.Propose.
2015-08-28 11:17:59 +02:00
df83af944b
Merge pull request #3384 from yichengq/fix-shadow
...
test: use go vet shadow feature instead of go-nyet
2015-08-27 14:27:57 -07:00
92cd24d5bd
*: fix govet shadow check failure
2015-08-27 14:15:30 -07:00
32372e1d70
raft: Fixed a test misassumption
...
network_test.go:56: total = 59.22354ms, want > 50ms
59 is > 50, but the equation added 10 to the right side
2015-08-27 15:15:34 -04:00
Gyu-Ho Lee