Commit Graph

14530 Commits (3a037744dee9a7df42d3469917e3b34c02ae0bb3)

Author SHA1 Message Date
Gyuho Lee 3a037744de
Merge pull request #9990 from jingyih/dev_workload_analysis_tool
etcdserver: add grpc interceptor to log info on incoming request to etcdserver
2018-08-10 23:15:04 -07:00
Xiang Li 11dd0b583b
Merge pull request #9982 from bdarnell/pagination
raft: Introduce CommittedEntries pagination
2018-08-11 09:12:46 +08:00
Jingyi Hu 368010d8a3 etcdserver: code clean up
Code clean up in interceptor.go
2018-08-10 16:29:42 -07:00
Gyuho Lee 59e084d37b
Merge pull request #9991 from dlipovetsky/snapshot-file-permission-release-note
CHANGELOG: Add 3.4 changelog entry for snapshot file permissions change
2018-08-10 14:07:57 -07:00
Daniel Lipovetsky f52a990340 CHANGELOG: Add 3.4 changelog entries for snapshot file permissions change 2018-08-10 13:37:25 -07:00
Jingyi Hu 30662940f4 vendor: add go-grpc-middleware
Rebased to master PR #9994.  Fixed a Go format issue in
v3rpc/interceptor.go.  Updated vendor to include go-grpc-middleware.
2018-08-10 13:15:35 -07:00
Jingyi Hu dc01734c6b etcdserver: add grpc interceptor to log info on incoming requests to
etcd server

To improve debuggability of etcd v3. Added a grpc interceptor to log
info on incoming requests to etcd server. The log output includes
remote client info, request content (with value field redacted), request
handling latency, response size, etc. Uses zap logger if available,
otherwise uses capnslog.

Also did some clean up on the chaining of grpc interceptors on server
side.
2018-08-10 11:01:07 -07:00
Gyuho Lee 457a96d931
Merge pull request #9994 from gyuho/grpc
vendor: upgrade google.golang.org/grpc to v1.14.0
2018-08-10 06:36:33 -07:00
Gyuho Lee 7e2e71ce7e words: whitelist "ErrConnClosing"
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-09 20:01:35 -07:00
Gyuho Lee 6c6bc3a200 vendor: upgrade google.golang.org/grpc to v1.14.0
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-09 19:36:35 -07:00
Gyuho Lee d726baf02c Gopkg.lock: regenerate with gRPC v1.14
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-09 19:36:18 -07:00
Gyuho Lee aeb418b815 clientv3/integration: remove "transport.ErrConnClosing" match
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-09 19:27:37 -07:00
Gyuho Lee 4fa58fc062
Merge pull request #9993 from philips/dash-force-new-cluster
Documentation: v2: add -- for force new cluster
2018-08-09 10:47:01 -07:00
Brandon Philips d05d522398 Documentation: v2: add -- for force new cluster
this doc is inconsistent between --force-new-cluster and
-force-new-cluster. Use the latter as it is the preferred option in
etcd.
2018-08-09 10:13:27 -07:00
Gyuho Lee d984482d1b README: warn about repository transfer
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-08 14:08:37 -07:00
Sam Batschelet 2fe491851e
Merge pull request #9977 from dlipovetsky/etcdctl-snapshot-permissions
clientv3: make saved snapshot readable by user only
2018-08-08 16:34:23 -04:00
Daniel Lipovetsky ddde272fb0 clientv3: Make saved snapshot readable by user only
Fixes #9976
2018-08-08 12:46:17 -07:00
Xiang Li 6002bf37ba
Merge pull request #9985 from bdarnell/flow-control
raft: Make flow control more aggressive
2018-08-08 10:11:54 -07:00
Ben Darnell a9e7c1e11f raft: Make flow control more aggressive
We allow multiple in-flight append messages, but prior to this change
the only way we'd ever send them is if there is a steady stream of new
proposals. Catching up a follower that is far behind would be
unnecessarily slow (this is exacerbated by a quirk of CockroachDB's
use of raft which limits our ability to catch up via snapshot in some
cases).

See cockroachdb/cockroach#27983
2018-08-08 11:10:54 -04:00
Gyuho Lee 6c9a853f04 CHANGELOG: add links to "List of metrics"
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-08 07:22:18 -07:00
Gyuho Lee fdab22c9c6
Merge pull request #9979 from gyuho/20180802-vendor-grpc
vendor: upgrade gRPC to v1.14.0
2018-08-07 14:35:28 -07:00
Ben Darnell 0a670b7c9b raft: Introduce CommittedEntries pagination
The MaxSizePerMsg setting is now used to limit the size of
Ready.CommittedEntries. This prevents out-of-memory errors if the raft
log has become very large and commits all at once.
2018-08-07 12:54:34 -04:00
Gyuho Lee 9ad8f4c350
Merge pull request #9983 from gyuho/20180806-clientv3-docs
docs: update gRPC, add feature comparison
2018-08-07 04:28:07 -07:00
Gyuho Lee 3599938cf0
Merge pull request #9984 from gyuho/20180806-metrics-all
docs,tools/etcd-dump-metrics: automate metrics documentation
2018-08-07 04:27:25 -07:00
Gyuho Lee b42a9ce20e
MAINTAINERS: change gyuho's email to AWS
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 20:54:41 -07:00
Ben Darnell bc14deecca raft: Add a test for MaxSizePerMsg feature
Ensure that this limit is respected when generating MsgApp messages.
2018-08-06 16:52:16 -04:00
Gyuho Lee 902893f231
docs: add all v3.1 metrics
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 10:02:22 -07:00
Gyuho Lee 2c1c191566
docs: add all v3.2 metrics
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:54:18 -07:00
Gyuho Lee e83d6c2234
docs: add all v3.3 metrics
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:31:53 -07:00
Gyuho Lee cf5dc560c8
tools/etcd-dump-metrics: automate metrics fetch from release binaries
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:30:52 -07:00
Gyuho Lee f457aafaf1
docs: move metrics files to sub-directory
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:29:52 -07:00
Gyuho Lee 9d1114f0db
docs: update monitoring index
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:28:59 -07:00
Gyuho Lee 0d189c661a
docs: add "Client Feature Matrix"
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:21:47 -07:00
Gyuho Lee fd000ae7ec
docs: update to "grpc1.14"
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:21:33 -07:00
Gyuho Lee 29590c9ab2
docs/img: update client architecture images
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-06 09:20:58 -07:00
Gyuho Lee 981644af7d
scripts/updatedep: remove "dep prune" command
"Pruning is now performed automatically by dep ensure."

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-02 08:06:27 -07:00
Gyuho Lee 612266beaf
vendor: upgrade gRPC to v1.14.0
https://github.com/grpc/grpc-go/releases/tag/v1.14.0

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-08-02 07:59:52 -07:00
Xiang Li 93be31d43a
Merge pull request #9968 from Quasilyte/quasilyte/fixCaseOrder
etcdctl/ctlv2/command: fix type switch case order
2018-07-29 11:38:31 -07:00
Xiang Li fa20b61c9f
Merge pull request #9970 from Quasilyte/quasilyte/namedConst
contrib/recipes: use clientv3.NoLease instead of 0
2018-07-29 11:37:39 -07:00
Xiang Li d1f49d4a40
Merge pull request #9969 from Quasilyte/quasilyte/boolExprSimplify
etcdserver/api/v2discovery: simplify !(x == y) to x != y
2018-07-28 15:47:05 -07:00
Iskander Sharipov 1de9e1b00d contrib/recipes: use clientv3.NoLease instead of 0
If we have a named const, it's more readable to use that.

Found using https://go-critic.github.io/overview#namedConst-ref
2018-07-28 23:56:45 +03:00
Iskander Sharipov d0f800c930 etcdserver/api/v2discovery: simplify !(x == y) to x != y
Found using https://go-critic.github.io/overview#boolExprSimplify-ref
2018-07-28 23:47:17 +03:00
Iskander Sharipov 3da90b6d3e etcdctl/ctlv2/command: fix type switch case order
Since syscall.Errno implements net.Error and all cases
are matched sequentially, it's a mistake to put syscall.Errno
case after net.Error since it will never be executed.

This change swaps syscall.Errno case with net.Error
to give that clause chance to execute.
2018-07-28 23:33:13 +03:00
Gyuho Lee 90a2fbe50e
Merge pull request #9966 from gyuho/maintainer
MAINTAINERS: add Joe Betz
2018-07-27 17:34:06 -07:00
Gyuho Lee df2190e382
MAINTAINERS: add Joe Betz
Joe has been helping fix lots of bugs and involved
in critical feature design/implementation,
plus leading patch release process for over a year.

Thanks for your excellent work.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-07-27 17:03:24 -07:00
Gyuho Lee f337e1b363
Merge pull request #9954 from spzala/etcdctlput
etcdctl: value should not be provided after \r
2018-07-27 13:50:49 -07:00
Gyuho Lee d16c8b3880
Merge pull request #8689 from nvanbenschoten/nvanbenschoten/commit
raft: don't allocate slice and sort on every commit
2018-07-27 13:50:04 -07:00
Joe Betz 1c382a4868
Merge pull request #9945 from jpbetz/balancer-maintanance-api-fix
clientv3: Fix maintenance APIs to directly dial grpc endpoints directly
2018-07-27 10:15:25 -07:00
Joe Betz 67bcf28c4e
clientv3: Use passthrough resolver for direct endpoint dialing 2018-07-27 10:15:02 -07:00
Nathan VanBenschoten 0a415cf0d6 raft: dont allocate slice and sort on every commit 2018-07-25 23:42:16 -04:00