Commit Graph

84 Commits (master)

Author SHA1 Message Date
Danny Al-Gaaf 86b994df05 gf_w32.c: add missing breaks
Since there is no comment indicating fallthrough on purpose added a
break in switch value 3 and 5/before default.

Fix for coverity issue from Ceph project:

CID 1193080 (#1 of 1): Missing break in switch (MISSING_BREAK)
 unterminated_case: This case (value 3) is not terminated by a 'break'
 statement.

CID 1193081 (#1 of 1): Missing break in switch (MISSING_BREAK)
 unterminated_case: This case (value 5) is not terminated by a 'break'
 statement.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-04-22 20:08:26 +02:00
Danny Al-Gaaf e958b0437d gf_w16.c: add missing break
Since there is no comment indicating fallthrough on purpose added a
break in switch value 5/before default.

Fix for coverity issue from Ceph project:

CID 1193079 (#1 of 1): Missing break in switch (MISSING_BREAK)
 unterminated_case: This case (value 5) is not terminated by a 'break'
 statement.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-04-22 20:08:26 +02:00
Danny Al-Gaaf 173f82442d gf_general.c: fix pointless expression
Instead of checking w128[0] twice check for w128[0] and w128[1].

Fix for coverity issue from Ceph project:

CID 1193072 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT)
 pointless_expression: The expression v1->w128[0] == v2->w128[0] &&
 v1->w128[0] == v2->w128[0] does not accomplish anything because it
 evaluates to either of its identical operands, v1->w128[0] == v2->w128[0].
 Did you intend the operands to be different?

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-04-22 20:08:26 +02:00
Kevin Greenan 1559c2b515 Merged in dachary/gf-complete/wip-uint-8 (pull request #19)
prefer uint8_t to char in pointer arithmetic
2014-04-10 19:01:49 -07:00
Loic Dachary a0ae760ed3 prefer uint8_t to char in pointer arithmetic
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-04-10 17:21:38 +02:00
Loic Dachary b5ac2580c2 TODO reminder for KMG/JSP about hardcoded constant
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-04-10 16:59:38 +02:00
Kevin Greenan 8a96cbb371 Ran autogen to pick-up the changes needed to run 'make check' 2014-04-02 10:35:21 -07:00
Kevin Greenan 4c84a3b650 Merged in dachary/gf-complete/wip-compilation-warnings (pull request #12)
fix void* arithmetic compilation warning
2014-03-31 08:53:14 -07:00
Loic Dachary d569220629 do not compile if used in SSE4 code path only
Acknowledge that gf_w128_split_4_128_multiply_region and
gf_w128_split_4_128_sse_multiply_region are only used when the
INTEL_SSE4 flag is present, even though they only need INTEL_SSSE3

It suppresses a compilation warning complaining about them not being
used if INTEL_SSE4 is absent and INTEL_SSSE3 is present.

Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-30 00:06:48 +01:00
Loic Dachary ce61fb053d fix void* arithmetic compilation warning
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-29 23:51:34 +01:00
Loic Dachary 20a242d9dd remove unused static function gf_w128_group_r_sse_init
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-28 16:06:29 +01:00
Jens Rosenboom 2758e242fe remove autogenerated files from repository 2014-03-18 21:53:24 +01:00
Loic Dachary cfcc1881ea remove unused argument from SSE_AB2
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:48:38 +01:00
Loic Dachary 191b86b5d2 remove unused variables from #if SSE blocs
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:48:38 +01:00
Loic Dachary cc45e19026 do not use gf_internal_t when it is null
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:48:12 +01:00
Loic Dachary 3c4a451b50 silence some warnings for unset variables
By setting them when they are defined and when the compiler fails to see
the logic is ok.

Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:47:59 +01:00
Loic Dachary d8863ceff7 remove duplicate headers from src
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:32:41 +01:00
Loic Dachary 29899ad443 move #if to avoid unused warning
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:32:30 +01:00
Loic Dachary 0020ff8092 initialize pointer early in the function
otherwise it may be used uninitialized

Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:29:58 +01:00
Loic Dachary d36bd6e540 cast void* to char* for pointer arithmetic
Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 17:29:36 +01:00
Loic Dachary f043479e3c remove unused variables
In some places move variables in the scope of the CPP define where they
are used.

Signed-off-by: Loic Dachary <loic@dachary.org>
2014-03-06 15:15:22 +01:00
Jim Plank 814240e336 Changed %d to %u in gf_general.c 2014-01-25 10:33:23 -05:00
Jim Plank f0c32c94bc Removed GROUP/128/SSE. It wasn't compiling, and it needed an overhaul.
I'll do it someday when I'm bored.
2014-01-01 11:00:40 -05:00
Jim Plank fb0bbdcf62 Fixed the problem with PCLMUL and gf_complete.h. Removed
ARCH_64 from everything but 128/GROUP/SSE.  Fortunately, no
one ever uses that.
2013-12-31 20:08:18 -05:00
Kevin Greenan 8900c0e635 Make INTEL_SSE4_PCLMUL flag consistent (was INTEL_PCLMUL in gf.c) 2013-12-30 22:12:43 -08:00
Kevin Greenan 5687b9c2cc Third.1 time's a charm (autoconf non-sense for PCLMUL). 2013-12-30 22:50:04 -08:00
Kevin Greenan 137b7ccd75 Revert "Third time's a charm (autoconf non-sense for PCLMUL)."
The commit was not successfully pushed (not sure what happened).

This reverts commit 762926920a.
2013-12-30 22:40:18 -08:00
Kevin Greenan 762926920a Third time's a charm (autoconf non-sense for PCLMUL). 2013-12-30 21:26:47 -08:00
Kevin Greenan a98f6c1115 Added entry to configure.ac to avoid running autotools during normal build. 2013-12-30 16:31:54 -08:00
Kevin Greenan a97563f0e4 Added PCLMUL to the autoconf macro... 2013-12-30 14:14:08 -08:00
Jim Plank 52376d9cc6 Copmiler errors with %llx. 2013-12-29 17:01:42 -05:00
Kevin Greenan ef18bccc3a Group for w=128 was failing because SSE4 is enabled, but not ARCH_64 (on my Linux VM). Ensure that both are defined
when init'ing group for w=128.
2013-12-10 09:00:32 -08:00
Kevin Greenan e1c76b4dd4 Added exhaustive test support (Ethan's changes to gf_unit and gf_methods) and overrode autoconf's defaults for CFLAGS. 2013-12-07 16:05:31 -08:00
Kevin Greenan 153dd20988 Setting up autoconf/automake for GF-Complete
Also re-organized the directory structure.

Signed-off-by: Kevin Greenan <kmgreen2@gmail.com>
2013-12-04 21:24:29 -08:00