kwin/effects/wobblywindows
Martin Gräßlin fb69b791a1 Ensure that all Effects honour the grab roles correctly
Summary:
When windows get added some effects grab the window and want to be the
only one animating this window. For this the grab roles exists. An
effect being notified later on evaluates the grab state and does not
start the animation.

This process failed due to being dependent on the order the effects are
loaded. Window Added/Closed are signals emitted by EffectsHandler, thus
first come, first serve. The requested effect order does not play into
it.

Due to that it could happen that an Effect which should not animate,
started to animate as the grab was still there.

This change adds the possibility to be notified whenever the window data
changes. A new signal is added to EffectsHandler which is emitted
whenever the windowData changes. The interested effects connect to it
and cancel their (just started) animation for the window.

Adjusted effects are:
* ScaleIn
* Fade
* WobblyWindows

In case of WobblyWindows an additional logical error was fixed that the
animations were only run when an effect grabbed instead of the other way
around.

BUG: 336866
FIXED-IN: 5.8.4

Reviewers: #kwin, #plasma, broulik

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3211
2016-11-07 11:45:09 +01:00
..
CMakeLists.txt Use SERVICE_TYPES parameter to kcoreaddons_desktop_to_json() 2015-12-09 23:42:45 +00:00
wobblywindows.cpp Ensure that all Effects honour the grab roles correctly 2016-11-07 11:45:09 +01:00
wobblywindows.h Ensure that all Effects honour the grab roles correctly 2016-11-07 11:45:09 +01:00
wobblywindows.kcfg fix wobblynnoyance kcfg group 2012-12-14 22:36:40 +01:00
wobblywindows_config.cpp Make constants const, saves a few symbols in the .data section. 2014-09-27 20:30:49 +02:00
wobblywindows_config.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2015-04-07 13:20:00 +00:00
wobblywindows_config.h [kwin/effects] Use generated dbus interface to reconfigure effects 2014-03-25 15:49:19 +01:00
wobblywindows_config.ui KIntSpinBox -> QSpinBox in kwin/effects configs 2013-09-09 07:38:30 +02:00
wobblywindowsconfig.kcfgc Use KConfigXT in Wobblywindows effect 2012-09-14 10:39:28 +02:00