vitalif
/
react-toolbox
1
0
Fork 0
Code Issues Pull Requests Releases 12 Wiki Activity

Remove unnecessary reference to sliderLength in knobOffset method (#1271)

old
dan-kwiat 2017-02-26 15:39:59 +00:00 committed by Javi Velasco
parent 3d2329a502
commit e7f521041e
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
components/slider/Slider.js
View File

@ -187,9 +187,8 @@ const factory = (ProgressBar, Input) => {
}
knobOffset() {
const { max, min } = this.props;
const translated = this.state.sliderLength * ((this.props.value - min) / (max - min));
return (translated * 100) / this.state.sliderLength;
const { max, min, value } = this.props;
return 100 * ((value - min) / (max - min));
}
move(position) {

3
components/slider/__tests__/index.spec.js
View File

@ -57,9 +57,8 @@ describe('Slider', () => {
});
describe('#knobOffset', () => {
it('returns the corresponding offset for a given value and slider length/start', () => {
it('returns percentage offset of knob for slider with given min/max/value props', () => {
const slider = shallow(<Slider min={-500} max={500} value={-250} />).instance();
slider.setState({ sliderStart: 500, sliderLength: 100 });
expect(slider.knobOffset()).toEqual(25);
});
});