Commit Graph

357 Commits (77355718c61db8354e17388fb15de09f6550bdcf)

Author SHA1 Message Date
pefu 77355718c6 Fix SF Bug [#489470] loginfo-handler broken due to rlog interface change
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@364 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-12-05 19:00:27 +00:00
pefu 19ab90b4fb note modified to take new templates into acount
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@363 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-12-05 14:57:41 +00:00
pefu 7a3c8bf9c4 Fix title string in cvsgraph output: path was missing. module is unsed by ViewCVS
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@362 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-12-05 14:52:59 +00:00
pefu d11dffb713 Table header should look left aligned and green similar
to the table headers in directory.ezt and query.ezt


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@361 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-27 22:13:30 +00:00
pefu 16281c1db5 A lot of small changes in one commit:
lib/viewcvs.py, templates/directory.ezt:
* Fix SF Bug [ #486085 ] checkout_magic_path uses invalid chars
  Provide backward compatibility for old style URLs.

standalone.py:
* Changed from calling viewcvs.main() to calling viewcvs.runcgi(),
  so that the timing results sampled by debug are displayed in the browser.

* Added two more toggles to the GUI.  Now it is simpler to perform a
  systematic test of several permutations of these config flags.

* Shortened the label text for the query entry field in the standalone GUI.

* Added some comments to this Tkinter GUI setup code, which has grown beyond
  than what I was my first intention.

lib/viewcvs.py, lib/config.py, cgi/viewcvs.conf.dist, standalone.py
and templates/directory.ezt:
* Added a new config flag variable called flip_links_in_dirview, which defaults
  to the classic setting (like cvsweb).  If it is set to 1 instead then the
  file and revision columns are exchanged and at the same time these two columns
  exchange the meaning of their links.  This design should solve the user
  interface design problem brought up first in
    http://www.lyra.org/pipermail/viewcvs-dev/2001-November/000285.html
  which was than than further discussed here:
    http://www.lyra.org/pipermail/viewcvs-dev/2001-November/000288.html
    http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/viewcvs/viewcvs/templates/Attic/direasy.ezt?hideattic=0
    http://www.lyra.org/pipermail/viewcvs/2001q4/000533.html
  Since than I received two personal emails from people sharing my POV.

  Unfortunately the huge [for rows]-block in directory.ezt has grown
  again.  But it is difficult to avoid this with the current design of
  lib/viewcvs.py and the templating engine lib/ezt.py.  I'm open to
  suggestions.

  In lib/viewcvs.py function view_directory I factored out the computation
  of row.span into a new local variable called span, since the number of
  empty trailing columns is decreased by one if the flip_links layout
  is configured.

templates/query.ezt:
* Rearranged the table columns in the commit database query result table,
  so that they match the existing table layouts of directory.ezt and
  log_table.ezt.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@360 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-27 21:56:06 +00:00
pefu 0da8dec361 * cutting a release should become even easier: Added tarball and .zip file
generation. (People using Windows often still prefer .zip over .tar.gz)
  fix permissions before generating the files.  Don't emit a an irritating
  warning, if someone tries this script to cut out viewcvs-0.7 again (even if
  solely done to test this script, before the v0_8 tag has been set ;-))


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@359 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-27 21:18:39 +00:00
pefu 1606e4e6dd Add entry field for query.ezt
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@358 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 22:52:02 +00:00
pefu 0393ef47f7 synchronize lib/config.py with viewcvs.conf.dist.
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@357 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 21:25:01 +00:00
pefu 3d9eb3c638 all externals links in italic.
Added more subsections.  Especially a procedure about what I
think how Greg is going to cut a ViewCVS release.
suggestions and corrections welcome.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@356 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 21:13:43 +00:00
pefu 6a0c6f2029 Log messages should look like they were
formatted in the first place. (see viewcvs.print_log() last line for
example, how the log message is displayed elsewhere


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@355 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 14:36:18 +00:00
timcera b564bd020a * Added apache_icons.py so that standalone.py works.
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@354 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 13:55:18 +00:00
pefu 889f71f657 Even on the 1600x1200 pixel display of my new DELL Inspiron the table
generated by query.cgi was unacceptable wide.

After I widened the browser window so that it occuoies the whole
screen width, it still required a horizontal scrollbar.
I find this unusable.  So I decided to remove the
Description column and put the Log message blocks on a separate
table row.

But since this may be a matter of taste, I left the original
stuff in, but commented out.  People with really large
screens (2000 pixels and up) might want to revert this change.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@353 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 12:09:55 +00:00
pefu 84188fafbb After cvs updating I got
Python Exception Occurred ... template.parse_file(os.path.join(viewcvs.g_template_dir,
AttributeError: g_template_dir

in query.py.  This was caused by the rename in viewcvs.py from 1.64 to 1.65
This was easy to find and easy to fix. ;-)
ViewCVS is great tool


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@352 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 11:15:18 +00:00
pefu eff0ddeabe Add the new debug module to the installer
installed viewcvs dies with an ImportError exception otherwise.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@351 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 10:22:28 +00:00
gstein d69802487f Revamp bin2inline to create lines that are less than 80 characters wide.
Regenerate the icons.

Suggested by: Peter Funk <pf@artcom-gmbh.de>


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@350 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 10:13:01 +00:00
gstein 0ff4aed795 Various changes:
* security: remove use of SimpleHTTPServer and just go with Base

* get the icons working -- send a 200 response line

* get redirects working by sending Location: header

* toss the PATH_TRANSLATED so we don't have to depend on .translate_path()

* use normal Python style for base invocation, rather than the self.base
  thing

* use SO_REUSEADDR if it is defined to avoid problems with stop/start of the
  server and rebinding to the socket


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@349 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 04:36:19 +00:00
gstein a4aa00b5f1 Just store the icons as binary strings rather than worrying about base64.
Both are equally unintelligible, so we may as well simplify.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@348 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 04:20:04 +00:00
gstein cef439958f Remove direasy.ezt.
directory.ezt incorporated its cvsgraph icon, so its only difference is
flipping the links around. But the existing definition for the links makes
more sense, so that leaves direasy.ezt without any new or interesting
features.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@347 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 03:11:21 +00:00
gstein 175d6f0ac4 Updates to the help stuff
* rename ~helppage~ magic path to ~docroot~ with the intent that we might
  serve other content out of there (including users' data if necessary)

* shift Help link down below the logo where it is more visible

* rename g_template_dir to its real semantic: g_install_dir

* rename view_helppage() to view_doc() and use new g_install_dir to find the
  doc root.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@346 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 02:59:13 +00:00
gstein 27df7480c5 Various tweaks:
* remove standalone comment from README; standard operation is to use a CGI
  script, so we don't want an incorrect emphasis; keep this discussion in
  INSTALL.

* clarify the GUI vs CGI operation description at the head of the file

* other updates/clarifications in INSTALL

* reformat a bit of text in the installer


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@345 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-19 01:10:08 +00:00
pefu 05bec0ce73 Advertise standalone.py ;-). And some cosmetic fixes
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@344 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 20:27:26 +00:00
pefu d7c84f3149 Fix unit test to take the new white space compression into
account.  Using this opportunity to update another not related
part of the module doc string.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@343 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 20:03:19 +00:00
pefu a0ece2036e Remove a superflous line of code and change the redirect response.
This should fix the first two of the five remarks made
by Greg Stein yesterday


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@342 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 14:04:41 +00:00
gstein fcec542cfb Add a new debug module for developers to do timing/profiling and similar
tasks. Add a bit of instrumentation for EZT template parsing.

Add whitespace reduction to EZT. On my box, this doubles the parse time of
directory.ezt from .03 to .06 seconds, and log.ezt from 0.047 to 0.1
seconds. (about double in both cases) My two samples showed a reduction in
the response size by about 25%.

Instrument the overall execution of ViewCVS to examine relative percentage
of template parsing.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@341 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 12:54:40 +00:00
gstein 37166f065c Remove the <tt> tags. They actually didn't force fixed-width when
diff_font_face said otherwise. Further, fixed-width isn't necessarily
"correct" here. Most people (SourceForge, Debian, ASF, handhelds.org, at
least) all run with proportional fonts.

Admins can set diff_font_face to switch to fixed-width.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@340 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 11:52:59 +00:00
gstein 983a2c298e Minor tweaks:
- "view annotated" rather than "view annotation" (we don't want to imply
  there is some kind of annotation facility; we really need a better word
  for this; and no... 'blame' isn't it :-)

- use a rowspan on the revision column


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@339 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 11:45:54 +00:00
gstein 51988428f2 Fix up the diff links:
* put them back on a single line

* restore ordering -- "previous" is the most common, so it goes first

* add the action text into Diff links for larger hit targets
  (idea from Stephen Lamm <slamm@yahoo-inc.com>)


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@338 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 11:30:27 +00:00
gstein 9a8c28d886 Shift some presentation code out of query.py; do the work in the template.
Also, make sure the result table isn't shown if we haven't run a query.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@337 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 11:11:38 +00:00
gstein 02db1bf262 Two nits: add some closing quotes to fix Emacs' font-lock; shift some code
outside of a try/except block (the try/except shouldn't apply).


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@336 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 10:36:45 +00:00
gstein b048907b6d Complete the conversion of the cvsdb query facility over to templates. This
was a "minimal impact" switch. A bit more cleanup is coming separately.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@335 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 10:34:35 +00:00
gstein 5e497355a4 Fix up how the cvsdb handles loading the configuration.
* cvsdb.py: provide for running out of the CVS working dir. pass the config
  to GetRlogData().

* rlog.py: stop reading the config here (it's a library module). accept the
  config object as a param.

* viewcvs-install: turn off install-time substitution for several files


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@334 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 10:29:31 +00:00
gstein 45d1849883 Enable [if-index REF first]
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@333 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-18 10:22:36 +00:00
pefu 1e082e2982 Bugfix: stdout redirection problem, which occured with enscript
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@332 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 22:41:01 +00:00
pefu 55a94583fa I've rewritten the handling of icons in 'standalone.py': Currently only
very few icons from the set of icons distributed with Apache are really
used within the ViewCVS templates.  I've simply converted them into
a tiny new module, which is imported and used by standalone.py.  Now
standalone.py is really 'standalone' and can be run without Apache
alltogether.  The former options '-i' and '--apache_root=' of standalone.py
are now obsolete and I've removed them again.

The tool 'bin2inline_py.py' that I have used to convert the icon files
into a single sourcecode file is a cut-and-rape-oneway script from
something I've written a while ago to put icons into some other Tkinter
standalone program.  I case someone wants to add another icon, I've
placed this hacked version into the tools subdirectory and modified
'make-release', so that it will not be included into the final
ViewCVS 0.8 tarball.

For those who want to run standalone directly from the ViewCVS
source distribution, I've added a new option '-r' (or --repository=)
to standalone.py, so that it is now possible to patch the default
path '/home/cvsroot' without having to setup a Symlink in /home
pointing to their repository.  (Not everybody has the permissions
to do that on their server.)


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@331 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 21:53:03 +00:00
pefu cb41e82e6b This hopefully corrects a mistake I made. The alternative would have
been to change all references to LICENSE.html sprinkled
over all source files.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@330 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 13:09:58 +00:00
pefu 2b2f813262 Add comment about policy to keep external links in italic
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@329 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 12:27:01 +00:00
gstein 679153a77c Use a more sophisticated pipe so that we can get the output of the MySQL
command. In the success case, nothing is printed. But for the error case, we
get the information about the error.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@328 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 11:20:08 +00:00
gstein 674a2ee494 incorporate the graph icon from direasy (add size params). keep the links
the same. eliminate the border around the image.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@327 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 09:25:19 +00:00
gstein 8930cd8736 * use 1% for the width to keep the column as skinny as possible
* use &nbsp; for spaces in the links on the left side (compensating for the
  above change)
* Open Source has a space in it :-)
* offsite links are italicized


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@326 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-17 08:58:30 +00:00
pefu bef73fd21a Improve error handling. Thanks to Tim Cera.
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@325 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-16 14:52:06 +00:00
timcera 9fdfe05d24 * Corrected the colspan option for the 'Log' row.
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@324 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 20:42:25 +00:00
timcera 70b05c8a5e * Added direasy.ezt to install.
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@323 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 20:17:16 +00:00
pefu 2bc61a621d direasy.ezt is a simple variation based on directory.ezt.
Recently Stephen Lamm wrote:
> Have file links go to the latest revision instead of the cvs log.
> When I click on the file name, I expect to get that file, and not
> some meta information about it. Another column next the name could
> have a link like "(Log)" to get that information. That would be
> more explicit. I find it strange to click on the revision number
> to get a file because I typically do not think of files in terms
> of revision numbers. (The revision number probably should not have
> a link on it at all.)

In this template the revision number carries a link to the Log
page  (so the meaning of both columns are simply swapped).
Additionally (if you enable cvsgraph) the text string "(graph)" is replaced
by a small 16x16 pixel icon.

I experimented with the suggestion to add the word '(Log)' to each
filename but in the end I think that both (graph) and (log)
waste a lot of valueable horizontal screen space.

If you want to try this template out, you can simply start
	./standalone.py --gui
in the viewcvs directory and select the radio button labeled
with 'direasy.ezt'.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@322 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 18:12:22 +00:00
pefu eae9e0131f Added the utc date (I missed that)
git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@321 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 18:00:56 +00:00
pefu 28ecb8c8f4 * Took out mentioning ViewCVS 0.5 (that was long ago).
* Added proper credit to Bill Fenner (see
	http://mailman.lyra.org/pipermail/viewcvs/2001q4/000521.html
  )
* Added some info about the upcoming Release 0.8.
* rearranged a lot of text and added section headings.
* Added links to each section to the navigation panel at the left side
  of the page.
* Added link to the download page of the mxDateTime extension, which is
  required by MySQLdb.
* Added links to the tracker @ SF for feature requests
  and bug reports where appropriate.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@320 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 15:01:44 +00:00
pefu 0642725543 Fixed packing alignment of check buttons.
And: Now it is easy to compare the outcome of different templates:
Just choose the template you want to use and click reload in
your browser window.

This is currently only implemented for the directory view and
the Log page template.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@319 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 10:52:33 +00:00
pefu ad9a3d8c07 Close SF patch #481914:
The included patch enables the Delphi colorizer
for .pas and .dpr files. Most code should be delphi or
some form of Turbo Pascal equivilent syntax if it uses
the .pas. Currently ViewCVS has this mapped to the
ANSI standard 'pascal' colorizer. I checked with
Michael van Canneyt, the maintainer of both the Pascal
and Delphi colorizers in Enscript and he recommended
this change.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@318 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 08:23:43 +00:00
timcera 7232487cf0 * Combined the 'Branches' and 'Tags' columns.
* Probably fixed the problem of many tags in the table.
* Minor format changes.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@317 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-15 02:10:26 +00:00
timcera 2e9bbd9be6 * Ran through a spell checker and corrected mistakes.
* Rearranged 'Prerequisites' and 'Optional' sections.
* Maybe some other minor clean-ups.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@316 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-14 15:06:31 +00:00
pefu 34b639106b lib/viewcvs.py:
1. Fix the group membership and ViewCVS believes unreadable-Bug pointed
    out by H. Wade Minter <minter@lunenburg.org> on the ViewCVS mailing
    list yesterday.
 2. Load configuration only once, even if the function main (or run_cgi)
    is called more than once.  This is needed to allow tinkering with the
    configuration on the fly without the need to edit the viewcvs.conf file.
standalone.py:
 * Several coment typos fixed and added more docstrings.
 * Add two check buttons to the GUI to allow tinkering with the two
   configuration variables 'use_cvsgraph' and 'use_enscript' without
   having to edit a viewcvs.conf file.
 * Allow testing of the cvsgraph feature directly from a CVS working
   working copy (cvsgraph needs to find cgi/cvsgraph.conf.dist in this
   case).
 * Added a new option to specify a path to the Apache icons used all over
   the templates.


git-svn-id: http://viewvc.tigris.org/svn/viewvc/trunk@315 8cb11bc2-c004-0410-86c3-e597b4017df7
2001-11-14 15:02:11 +00:00