vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

Fix vitastor-cli ls --tree hiding layers whose parent is filtered out #101

Merged
vitalif merged 1 commits from koolkhel/vitastor:cli-ls-tree into master 2026-10-25 22:24:07 +03:00
Conversation 0 Commits 1 Files Changed 3 +48 -1
koolkhel commented 2026-10-25 16:14:57 +03:00
Contributor
Copy Link

Description

ls --tree built the tree starting from the roots of the selected layers,
so a layer whose parent was left out by a glob, -p or -n was never
reached and not printed at all: ls --tree testimg printed nothing when
testimg had a parent. Show such a layer as a root; its parent is still
shown in the PARENT column.

Tested: new tests/test_ls_tree.sh (testimg@snap1 with children testimg, testclone and testclone2 in another pool; ls --tree testimg, -n 1, -p testpool2), fails without the fix and passes with it.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description ls --tree built the tree starting from the roots of the selected layers, so a layer whose parent was left out by a glob, -p or -n was never reached and not printed at all: ls --tree testimg printed nothing when testimg had a parent. Show such a layer as a root; its parent is still shown in the PARENT column. Tested: new tests/test_ls_tree.sh (`testimg@snap1` with children testimg, testclone and testclone2 in another pool; `ls --tree testimg`, `-n 1`, `-p testpool2`), fails without the fix and passes with it. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 1 commit 2026-10-25 16:14:58 +03:00
Fix vitastor-cli ls --tree hiding layers whose parent is filtered out 90402ed55b 
ls --tree built the tree starting from the roots of the selected layers,
so a layer whose parent was left out by a glob, -p or -n was never
reached and not printed at all: ls --tree testimg printed nothing when
testimg had a parent. Show such a layer as a root; its parent is still
shown in the PARENT column.
vitalif merged commit 176d1d16ef into master 2026-10-25 22:24:07 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#101
No description provided.
Delete Branch "koolkhel/vitastor:cli-ls-tree"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?