vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 112 Wiki Activity

Fix missing space in vitastor-cli rm-osd "still up" message #103

Closed
koolkhel wants to merge 1 commits from koolkhel/vitastor:cli-rm-osd-msg into master
pull from: koolkhel/vitastor:cli-rm-osd-msg
merge into: vitalif:master
Conversation 1 Commits 1 Files Changed 3 +18 -1
koolkhel commented 2026-10-25 16:15:02 +03:00
Contributor
Copy Link

Description

rm-osd printed "OSD 1is still up" and "OSDs 2, 3are still up" because
the verb was appended to the OSD list without a space. Also say "it"
instead of "them" when only one OSD is up.

Tested: new tests/test_rm_osd_msg.sh, fails without the fix and passes with it.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description rm-osd printed "OSD 1is still up" and "OSDs 2, 3are still up" because the verb was appended to the OSD list without a space. Also say "it" instead of "them" when only one OSD is up. Tested: new tests/test_rm_osd_msg.sh, fails without the fix and passes with it. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 1 commit 2026-10-25 16:15:03 +03:00
Fix missing space in vitastor-cli rm-osd "still up" message be45066d08 
rm-osd printed "OSD 1is still up" and "OSDs 2, 3are still up" because
the verb was appended to the OSD list without a space. Also say "it"
instead of "them" when only one OSD is up.
vitalif commented 2026-10-25 17:18:17 +03:00
Owner
Copy Link

Замержил без теста, совсем мелочь

Замержил без теста, совсем мелочь
vitalif closed this pull request 2026-10-25 17:18:17 +03:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#103
No description provided.
Delete Branch "koolkhel/vitastor:cli-rm-osd-msg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?