vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

Correct vitastor-cli help for rm, raw-ls, fix and rm-osd #105

Merged
vitalif merged 1 commits from koolkhel/vitastor:cli-help-text into master 2026-10-25 17:11:15 +03:00
Conversation 0 Commits 1 Files Changed 3 +41 -27
koolkhel commented 2026-10-25 16:15:07 +03:00
Contributor
Copy Link

Description

  • rm: the --exact and --matching descriptions were swapped.
  • raw-ls: show that --pool_id is required, and --pg_num unless --offset
    is given, and when the pool configuration fills in the rest.
  • fix: show --bad-osds as required.
  • rm-osd: describe -f, --allow-up and --allow-data-loss. Up OSDs are
    refused too, -f covers them and degraded/offline PGs, and
    --allow-data-loss covers incomplete ones and implies -f.

Apply the same corrections to the CLI documentation.

Tested: help text and documentation only, no test.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description - rm: the --exact and --matching descriptions were swapped. - raw-ls: show that --pool_id is required, and --pg_num unless --offset is given, and when the pool configuration fills in the rest. - fix: show --bad-osds as required. - rm-osd: describe -f, --allow-up and --allow-data-loss. Up OSDs are refused too, -f covers them and degraded/offline PGs, and --allow-data-loss covers incomplete ones and implies -f. Apply the same corrections to the CLI documentation. Tested: help text and documentation only, no test. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 1 commit 2026-10-25 16:15:08 +03:00
Correct vitastor-cli help for rm, raw-ls, fix and rm-osd abd4410a5c 
- rm: the --exact and --matching descriptions were swapped.
- raw-ls: show that --pool_id is required, and --pg_num unless --offset
  is given, and when the pool configuration fills in the rest.
- fix: show --bad-osds as required.
- rm-osd: describe -f, --allow-up and --allow-data-loss. Up OSDs are
  refused too, -f covers them and degraded/offline PGs, and
  --allow-data-loss covers incomplete ones and implies -f.

Apply the same corrections to the CLI documentation.
vitalif merged commit 0fa2dd6646 into master 2026-10-25 17:11:15 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#105
No description provided.
Delete Branch "koolkhel/vitastor:cli-help-text"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?