Report netlink-map failures in its exit status #121
Open
koolkhel
wants to merge 1 commits from
koolkhel/vitastor:nbd-netlink-map-status into master
pull from: koolkhel/vitastor:nbd-netlink-map-status
merge into: vitalif:master
vitalif:master
vitalif:tombstones
vitalif:primary-stickiness
vitalif:libvfn
vitalif:canceling
vitalif:immediate-repeering
vitalif:rdma-close-tcp
vitalif:use-degraded-writes
vitalif:fix-write-delete-flow
vitalif:openssl-3.0.12
vitalif:openssl-capture-secrets
vitalif:ignore-small-rdma-end
vitalif:encrypt-batch
vitalif:faster-peering-calc
vitalif:http-hello
vitalif:xxh3-bench
vitalif:create-user-etcd-based
vitalif:aesxts_streaming_nosupport
vitalif:refactor-heap-continue-write
vitalif:ston3lu-patch-0127
vitalif:rdma-credits
vitalif:heap-meta
vitalif:sendmsg-zc-no-more-error
vitalif:fix-clear-refs
vitalif:veeam-trick
vitalif:test-etcd-schizo
vitalif:test
vitalif:test1
vitalif:test2
vitalif:cow-meta
vitalif:kv-readahead
vitalif:qemu-fix-crash-idea
vitalif:eventloop-auto-init-trigger
vitalif:hugo-docs
vitalif:node-mutex-and-postpone
vitalif:check-writeback
vitalif:msgr-iothreads-v2
vitalif:antietcd
vitalif:rel-1.4
vitalif:test-fix-ec-unknown-state-51
vitalif:kv-update
vitalif:kv-debug
vitalif:hotfix-1.2.0
vitalif:rdma-simple-nodp
vitalif:zerocopy-tcp-send
vitalif:csi-staging
vitalif:hotfix-1.1.0
vitalif:hotfix-1.0.0
vitalif:fsync-feedback
vitalif:cached-reads
vitalif:qemu-send-loop
vitalif:test-double-alloc
vitalif:hier-failure-domains
vitalif:mon-self-restart
vitalif:epoch-deletions
vitalif:rdma-flow-control
vitalif:csi-use-vitastor-cli
vitalif:rdma-v2
vitalif:etcd-hide-base64
vitalif:lrc-matrix
vitalif:rm-left-on-dead
vitalif:nfs-proxy-old
vitalif:non-odp-rdma
vitalif:test-zctr
vitalif:separate-data-connections
vitalif:sec_osd_msgr
vitalif:test-assert
vitalif:nbd-vmsplice
vitalif:allow-etcd-address-option
vitalif:rdma-zerocopy
vitalif:rel-0.5
vitalif:openonload
vitalif:sync-io-test
vitalif:trace-sync
vitalif:trace-sqes
vitalif:test-submit-and-wait
vitalif:test-sq-poll
vitalif:blocking-uring-test
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "koolkhel/vitastor:nbd-netlink-map-status"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
netlink-mapandnetlink-reviveforked before configuring the device, and the parent exited 0 at once. So a failed configuration (a busy device, no permission, no nbd netlink family) still returned 0, and the command could return before the device was set up. With this change the parent waits until the daemon sends the device number, and exits 1 if the daemon dies first.Tested as non-root against an empty local etcd, with
netlink-map --inode 1 --pool 1 --size 1073741824, wherenetlink_configure()fails withOperation not permitted. Before the change, the command exited 0 while the daemon printed the error. After it, the command exits 1 with the same error, and--foregroundexits 1 too.Contributor Name
Yury Luneff (MIND Software LLC, https://mindsw.io)
CLA
@@ -825,6 +829,41 @@ help:exit(0);}// Like daemonize_fork(), but the parent prints the device and exits 0 onlyЕсли хочется такое сделать, нужно скопипастить с ublk_server, там по идее такая же штука реализована уже, не нужно чтобы в двух файлах было 2 разных реализации примерно одного и того же, и также не надо чтобы было аж 4 функции - daemonize_fork, daemonize_reopen_stdio, daemonize_begin, daemonize_end
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.