[DNM] osd: run calc_object_states off the OSD thread #123
Open
lei.xianqiang
wants to merge 1 commits from
lei.xianqiang/vitastor:calc_object_states_in_worker_threads into master
pull from: lei.xianqiang/vitastor:calc_object_states_in_worker_threads
merge into: vitalif:master
vitalif:master
vitalif:tombstones
vitalif:primary-stickiness
vitalif:libvfn
vitalif:canceling
vitalif:immediate-repeering
vitalif:rdma-close-tcp
vitalif:use-degraded-writes
vitalif:fix-write-delete-flow
vitalif:openssl-3.0.12
vitalif:openssl-capture-secrets
vitalif:ignore-small-rdma-end
vitalif:encrypt-batch
vitalif:faster-peering-calc
vitalif:http-hello
vitalif:xxh3-bench
vitalif:create-user-etcd-based
vitalif:aesxts_streaming_nosupport
vitalif:refactor-heap-continue-write
vitalif:ston3lu-patch-0127
vitalif:rdma-credits
vitalif:heap-meta
vitalif:sendmsg-zc-no-more-error
vitalif:fix-clear-refs
vitalif:veeam-trick
vitalif:test-etcd-schizo
vitalif:test
vitalif:test1
vitalif:test2
vitalif:cow-meta
vitalif:kv-readahead
vitalif:qemu-fix-crash-idea
vitalif:eventloop-auto-init-trigger
vitalif:hugo-docs
vitalif:node-mutex-and-postpone
vitalif:check-writeback
vitalif:msgr-iothreads-v2
vitalif:antietcd
vitalif:rel-1.4
vitalif:test-fix-ec-unknown-state-51
vitalif:kv-update
vitalif:kv-debug
vitalif:hotfix-1.2.0
vitalif:rdma-simple-nodp
vitalif:zerocopy-tcp-send
vitalif:csi-staging
vitalif:hotfix-1.1.0
vitalif:hotfix-1.0.0
vitalif:fsync-feedback
vitalif:cached-reads
vitalif:qemu-send-loop
vitalif:test-double-alloc
vitalif:hier-failure-domains
vitalif:mon-self-restart
vitalif:epoch-deletions
vitalif:rdma-flow-control
vitalif:csi-use-vitastor-cli
vitalif:rdma-v2
vitalif:etcd-hide-base64
vitalif:lrc-matrix
vitalif:rm-left-on-dead
vitalif:nfs-proxy-old
vitalif:non-odp-rdma
vitalif:test-zctr
vitalif:separate-data-connections
vitalif:sec_osd_msgr
vitalif:test-assert
vitalif:nbd-vmsplice
vitalif:allow-etcd-address-option
vitalif:rdma-zerocopy
vitalif:rel-0.5
vitalif:openonload
vitalif:sync-io-test
vitalif:trace-sync
vitalif:trace-sqes
vitalif:test-submit-and-wait
vitalif:test-sq-poll
vitalif:blocking-uring-test
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "lei.xianqiang/vitastor:calc_object_states_in_worker_threads"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Sorting and walking every object version inside the OSD loop used to
stall OSD_OP_PING past osd_ping_timeout, so peers declared the OSD dead.
The calculation now runs on pg-calc threads. It only touches a scratch PG.
The main thread installs the result at the start of the next loop, before
peering, and swaps the object maps so pointers into state_dict stay valid.
stop and repeer bump calc_gen. A job that has not entered
calc_object_states is dropped at once, so the new peering can LIST
without waiting out a stale sort. A job already inside the calculation
finishes, and its result is discarded. calc_inflight_gen names that
in-flight job, so its completion clears only its own calc_running and
cannot drop a calculation submitted later.
relock_pg does not dereference peering_state while the worker owns it.
Tests stay on the synchronous path because the mock ring loop does not
poll eventfd.
Contributor Name
Xianqiang Lei (Datatom, https://www.datatom.com/)
CLA
Do not merge; this is only to discuss the test data for the currently committed code.
Increasing the object size can significantly shorten the peering duration. These data can also serve as reference data for peering optimization.
e5dbfb8a0fto24d89be551View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.