vitastor-disk: Check prepare options before partitioning, don't reuse damaged OSD partitions #139
Open
koolkhel
wants to merge 5 commits from
koolkhel/vitastor:prepare-check-before-partitioning into master
pull from: koolkhel/vitastor:prepare-check-before-partitioning
merge into: vitalif:master
vitalif:master
vitalif:primary-stickiness
vitalif:libvfn
vitalif:canceling
vitalif:immediate-repeering
vitalif:rdma-close-tcp
vitalif:use-degraded-writes
vitalif:fix-write-delete-flow
vitalif:openssl-3.0.12
vitalif:openssl-capture-secrets
vitalif:ignore-small-rdma-end
vitalif:encrypt-batch
vitalif:faster-peering-calc
vitalif:http-hello
vitalif:xxh3-bench
vitalif:create-user-etcd-based
vitalif:aesxts_streaming_nosupport
vitalif:refactor-heap-continue-write
vitalif:ston3lu-patch-0127
vitalif:rdma-credits
vitalif:heap-meta
vitalif:sendmsg-zc-no-more-error
vitalif:fix-clear-refs
vitalif:veeam-trick
vitalif:test-etcd-schizo
vitalif:test
vitalif:test1
vitalif:test2
vitalif:cow-meta
vitalif:kv-readahead
vitalif:qemu-fix-crash-idea
vitalif:eventloop-auto-init-trigger
vitalif:hugo-docs
vitalif:node-mutex-and-postpone
vitalif:check-writeback
vitalif:msgr-iothreads-v2
vitalif:antietcd
vitalif:rel-1.4
vitalif:test-fix-ec-unknown-state-51
vitalif:kv-update
vitalif:kv-debug
vitalif:hotfix-1.2.0
vitalif:rdma-simple-nodp
vitalif:zerocopy-tcp-send
vitalif:csi-staging
vitalif:hotfix-1.1.0
vitalif:hotfix-1.0.0
vitalif:fsync-feedback
vitalif:cached-reads
vitalif:qemu-send-loop
vitalif:test-double-alloc
vitalif:hier-failure-domains
vitalif:mon-self-restart
vitalif:epoch-deletions
vitalif:rdma-flow-control
vitalif:csi-use-vitastor-cli
vitalif:rdma-v2
vitalif:etcd-hide-base64
vitalif:lrc-matrix
vitalif:rm-left-on-dead
vitalif:nfs-proxy-old
vitalif:non-odp-rdma
vitalif:test-zctr
vitalif:separate-data-connections
vitalif:sec_osd_msgr
vitalif:test-assert
vitalif:nbd-vmsplice
vitalif:allow-etcd-address-option
vitalif:rdma-zerocopy
vitalif:rel-0.5
vitalif:openonload
vitalif:sync-io-test
vitalif:trace-sync
vitalif:trace-sqes
vitalif:test-submit-and-wait
vitalif:test-sq-poll
vitalif:blocking-uring-test
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "koolkhel/vitastor:prepare-check-before-partitioning"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Commits for
vitastor-disk preparewith a device list:prepare_one(), after the disk was already partitioned. Options that can't work, for example--block_size 4M --data_csum_type crc32c --csum_block_size 4k(more checksums than fit into one metadata block), left the disk with empty OSD partitions. Now the options are checked for every disk before any partition is created, with the same HDD defaults asprepare_one().--dry-runrefuses them too.read_osd_superblock(dev, false)returned null both for a missing superblock and for a damaged one (valid magic, bad size, checksum or JSON) or an unreadable partition.get_new_data_parts()already uses empty OSD partitions on a disk that passes themax_other_percentcheck, and took such a partition for an empty one;--data_devicewithout--forcecreated an OSD on it too, although the old OSD could still be repaired by rewriting its superblock.read_osd_superblock()now reports a damaged superblock through an optional out-parameter; prepare skips such a partition in a device list and refuses it without--force.sectorsize, asfree_from_parttable()does (before, initialized OSD partitions counted as zero bytes then).Tested:
tests/test_resize_auto.shandOLD=1 tests/test_resize_auto.shpass. With the damaged-superblock skip disabled, the check of commits 3 and 4 fails. Merges cleanly with current master (after #134) and #137.Contributor Name
Yury Luneff (MIND Software LLC, https://mindsw.io)
CLA
vitastor-disk: Check prepare options before partitioning, reuse empty OSD partitionsto vitastor-disk: Check prepare options before partitioning, reuse only empty OSD partitionsТут не нужно добавлять переиспользование пустых разделов. Генеральная линия такая - если есть пустой/непонятный раздел, не трогаем его, пусть юзер его явно удалит и тогда можно создавать новый.
выше отписал (требуется коммент при request changes)
vitastor-disk: Check prepare options before partitioning, reuse only empty OSD partitionsto vitastor-disk: Check prepare options before partitioning, don't reuse damaged OSD partitionsУбрал в
52d16e66: пустые разделы OSD больше не считаются местом под OSD, и диск с пустым или непонятным разделом пропускается, как раньше. В PR остались проверка параметров до разметки и защита раздела с битым суперблоком или суперблоком другого устройства: в списке дисков такой раздел пропускается, а с--data_deviceбез--forceprepare от него отказывается.В Telegram вы написали, что пустые разделы вообще не надо подхватывать автоматически. Сейчас
get_new_data_parts()в master ещё берёт мелкие пустые разделы OSD, если диск проходит проверкуmax_other_percent. Предлагаю убрать и это: тогда проверка битого суперблока в режиме списка не нужна, останется только отказ с--data_deviceбез--force. Если согласны, сделаю отдельным коммитом в этом PR.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.