Test dd conv=noerror with a failing in-order write #145

Open
koolkhel wants to merge 1 commits from koolkhel/vitastor:dd-noerror-tests into master
Contributor

Description

A follow-up to #133, test only:

  • #133 made in-order writes advance by the blocks taken, so that an ignored write error does not stop them, but only its read half had a test. The new case writes to /dev/full, which fails every write with ENOSPC. Without that change, dd hangs.
  • The /sys/class/net/lo/speed case now reads one block (count=1). The file's size is the page size, so on a 64K-page kernel dd copied 64 KiB and the 4 KiB comparison failed.

Tested: the /dev/full case fails (timeout) with the dd code from before #133. The whole tests/test_dd.sh passes on master.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description A follow-up to #133, test only: - #133 made in-order writes advance by the blocks taken, so that an ignored write error does not stop them, but only its read half had a test. The new case writes to `/dev/full`, which fails every write with ENOSPC. Without that change, dd hangs. - The `/sys/class/net/lo/speed` case now reads one block (`count=1`). The file's size is the page size, so on a 64K-page kernel dd copied 64 KiB and the 4 KiB comparison failed. Tested: the `/dev/full` case fails (timeout) with the dd code from before #133. The whole `tests/test_dd.sh` passes on master. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 1 commit 2026-11-21 12:38:23 +03:00
#133 made in-order writes advance by the blocks taken, so that an
ignored write error does not stop them, but only its read half had a
test. Write to /dev/full, which fails every write with ENOSPC: without
that change dd hangs.

Also read only one block of /sys/class/net/lo/speed. Its size is the
page size, so on a 64K-page kernel dd copied 64 KiB and the 4 KiB
comparison failed.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u dd-noerror-tests:koolkhel-dd-noerror-tests
git checkout koolkhel-dd-noerror-tests
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#145
No description provided.