Capture client init errors in qemu_driver without io_uring too #151
Open
koolkhel
wants to merge 1 commits from
koolkhel/vitastor:qemu-nouring-exit into master
pull from: koolkhel/vitastor:qemu-nouring-exit
merge into: vitalif:master
vitalif:master
vitalif:primary-stickiness
vitalif:libvfn
vitalif:canceling
vitalif:immediate-repeering
vitalif:rdma-close-tcp
vitalif:use-degraded-writes
vitalif:fix-write-delete-flow
vitalif:openssl-3.0.12
vitalif:openssl-capture-secrets
vitalif:ignore-small-rdma-end
vitalif:encrypt-batch
vitalif:faster-peering-calc
vitalif:http-hello
vitalif:xxh3-bench
vitalif:create-user-etcd-based
vitalif:aesxts_streaming_nosupport
vitalif:refactor-heap-continue-write
vitalif:ston3lu-patch-0127
vitalif:rdma-credits
vitalif:heap-meta
vitalif:sendmsg-zc-no-more-error
vitalif:fix-clear-refs
vitalif:veeam-trick
vitalif:test-etcd-schizo
vitalif:test
vitalif:test1
vitalif:test2
vitalif:cow-meta
vitalif:kv-readahead
vitalif:qemu-fix-crash-idea
vitalif:eventloop-auto-init-trigger
vitalif:hugo-docs
vitalif:node-mutex-and-postpone
vitalif:check-writeback
vitalif:msgr-iothreads-v2
vitalif:antietcd
vitalif:rel-1.4
vitalif:test-fix-ec-unknown-state-51
vitalif:kv-update
vitalif:kv-debug
vitalif:hotfix-1.2.0
vitalif:rdma-simple-nodp
vitalif:zerocopy-tcp-send
vitalif:csi-staging
vitalif:hotfix-1.1.0
vitalif:hotfix-1.0.0
vitalif:fsync-feedback
vitalif:cached-reads
vitalif:qemu-send-loop
vitalif:test-double-alloc
vitalif:hier-failure-domains
vitalif:mon-self-restart
vitalif:epoch-deletions
vitalif:rdma-flow-control
vitalif:csi-use-vitastor-cli
vitalif:rdma-v2
vitalif:etcd-hide-base64
vitalif:lrc-matrix
vitalif:rm-left-on-dead
vitalif:nfs-proxy-old
vitalif:non-odp-rdma
vitalif:test-zctr
vitalif:separate-data-connections
vitalif:sec_osd_msgr
vitalif:test-assert
vitalif:nbd-vmsplice
vitalif:allow-etcd-address-option
vitalif:rdma-zerocopy
vitalif:rel-0.5
vitalif:openonload
vitalif:sync-io-test
vitalif:trace-sync
vitalif:trace-sqes
vitalif:test-submit-and-wait
vitalif:test-sq-poll
vitalif:blocking-uring-test
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "koolkhel/vitastor:qemu-nouring-exit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
qemu_driver passes
client_exit_on_error=0only when it creates the client with io_uring. When io_uring isn't available (seccomp profile,kernel.io_uring_disabled, old kernel) it falls back tovitastor_c_create_qemu(), which takes no options, so an initialization error (for example an unreachable etcd) still callsexit(1)and kills the whole QEMU process, for example on a disk hot-plug into a running VM.This adds
vitastor_c_create_qemu_json(), which takes the same option list asvitastor_c_create_uring_json(), and uses it in the fallback path (VITASTOR_C_API_VERSION7). A driver built against an older library keeps callingvitastor_c_create_qemu().One behaviour difference in the fallback path: it now gets its options from the same string list as the io_uring path. The
vitastor:filename syntax storesuse-rdma,rdma-gid-indexandrdma-mtuas integers, and that list doesn't pick integers up (qdict_get_try_str), so in the fallback path they are no longer read. The io_uring path already ignores them the same way.Tested: the same patch in our downstream tree, QEMU 8.2.2 running with
io_uring_setup()failing with ENOSYS (seccomp filter).blockdev-addof a disk with an etcd address that refuses connections returns a QMP error and QEMU keeps running; the same image then opens with the right address,blockdev-delandquitwork. Without the patch QEMU exits with code 1 on thatblockdev-add.Contributor Name
Yury Luneff (MIND Software LLC, https://mindsw.io)
CLA
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.