Report invalid osd_network as a fatal error instead of an exception #152

Merged
vitalif merged 2 commits from koolkhel/vitastor:osd-network-fatal into master 2026-11-23 00:09:19 +03:00

2 Commits

Author SHA1 Message Date
347bde7673 Return an error from cidr_parse() instead of throwing
parse_config() checks the result and reports an invalid osd_network
or osd_cluster_network through fatal_error() without try/catch.
2026-11-22 23:19:25 +03:00
49e64ede86 Report invalid osd_network as a fatal error instead of an exception
cidr_parse() throws on an invalid mask and osd_messenger_t::parse_config()
doesn't catch it, so a typo in osd_network or osd_cluster_network ends
in std::terminate(). In a process that embeds the client (QEMU) this
aborts it even with client_exit_on_error=false.

Report it through fatal_error(), like an invalid proto_checksums value.
2026-11-22 20:31:37 +03:00