vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

fix(openapi): give /osd/modify and /data/fix unique operationIds #82

Merged
vitalif merged 1 commits from epicstyt/vitastor:fix-openapi-for-ogen into master 2026-09-02 19:39:31 +03:00
Conversation 1 Commits 1 Files Changed 1 +2 -2
epicstyt commented 2026-09-01 16:35:12 +03:00
Contributor
Copy Link

Description

operationId must be unique in the document: /osd/modify carried osdDelete and /data/fix carried dataDelete, renamed to osdModify and dataFix — spec-only, no behaviour change.

Contributor Name

Stepan Rabotkin

CLA

### Description `operationId` must be unique in the document: `/osd/modify` carried `osdDelete` and `/data/fix` carried `dataDelete`, renamed to `osdModify` and `dataFix` — spec-only, no behaviour change. ### Contributor Name Stepan Rabotkin ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
epicstyt added 1 commit 2026-09-01 16:35:12 +03:00
fix(openapi): give /osd/modify and /data/fix unique operationIds 28da1d0e10 
Duplicate operationIds are forbidden outright by the OpenAPI
specification: the field must be unique among all operations in the
document. Two endpoints violated it by carrying the id of their
neighbouring delete operation, most likely copy-paste leftovers:
/osd/modify was osdDelete and /data/fix was dataDelete.

Rename them to osdModify and dataFix. Client generators derive method
names from operationId, so besides restoring validity this stops the
duplicates from silently colliding or being renamed by the generator.

Signed-off-by: Stepan Rabotkin <epicstyt@gmail.com>
vitalif approved these changes 2026-09-02 19:39:21 +03:00
vitalif merged commit 145942fc3c into master 2026-09-02 19:39:31 +03:00
vitalif deleted branch fix-openapi-for-ogen 2026-09-02 19:39:31 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
vitalif
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#82
No description provided.
Delete Branch "epicstyt/vitastor:fix-openapi-for-ogen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?