vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

Fix segfault in vitastor-cli serve without TLS #85

Merged
vitalif merged 1 commits from epicstyt/vitastor:fix-serve-plain-http-segfault into master 2026-09-02 19:43:20 +03:00
Conversation 1 Commits 1 Files Changed 1 +11
epicstyt commented 2026-09-02 15:15:42 +03:00
Contributor
Copy Link

Description

Serving plain HTTP segfaults on the first accepted connection — zero bytes sent is enough. http_ctx (src/cmd/cli_serve.cpp:81) is assigned only in the TLS branch, so it stays NULL, and http_init() dereferences it unchecked (src/client/http_client.cpp:278). The added else builds a context with empty cert/key/CA: http_context_init skips all certificate loading and ssl stays false.

Contributor Name

Stepan Rabotkin

CLA

### Description Serving plain HTTP segfaults on the first accepted connection — zero bytes sent is enough. `http_ctx` (`src/cmd/cli_serve.cpp:81`) is assigned only in the TLS branch, so it stays NULL, and `http_init()` dereferences it unchecked (`src/client/http_client.cpp:278`). The added `else` builds a context with empty cert/key/CA: `http_context_init` skips all certificate loading and `ssl` stays false. ### Contributor Name Stepan Rabotkin ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
epicstyt added 1 commit 2026-09-02 15:15:43 +03:00
fix(cli): create an http context when serving plain HTTP 102bc96bad 
http_ctx was assigned only in the TLS branch, so on plain HTTP it stayed
NULL and http_init() segfaulted on the first accepted connection.

Signed-off-by: Stepan Rabotkin <epicstyt@gmail.com>
vitalif approved these changes 2026-09-02 19:43:10 +03:00
vitalif merged commit 26c6251888 into master 2026-09-02 19:43:20 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
vitalif
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#85
No description provided.
Delete Branch "epicstyt/vitastor:fix-serve-plain-http-segfault"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?