vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

osd: call deref_object_state on recheck_state mismatch in remove_object_from_state #91

Merged
vitalif merged 1 commits from changwei.ye/vitastor:fix-remove-object-from-state into master 2026-10-17 21:21:35 +03:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
changwei.ye commented 2026-10-15 07:06:10 +03:00
Contributor
Copy Link

Description

osd: call deref_object_state on recheck_state mismatch in remove_object_from_state

When recheck_state != *object_state, the old object_state reference should be
released via deref_object_state() instead of raw ref_count--. Otherwise, if the
old state has no remaining objects (object_count == 0) and this was its last
reference, it would never be erased from pg.state_dict, leaking memory and state
dictionary entries.

Contributor Name

Changwei Ye (Datatom, https://www.datatom.com/)

CLA

### Description osd: call deref_object_state on recheck_state mismatch in remove_object_from_state When recheck_state != *object_state, the old object_state reference should be released via deref_object_state() instead of raw ref_count--. Otherwise, if the old state has no remaining objects (object_count == 0) and this was its last reference, it would never be erased from pg.state_dict, leaking memory and state dictionary entries. ### Contributor Name Changwei Ye (Datatom, https://www.datatom.com/) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
changwei.ye added 1 commit 2026-10-15 07:06:11 +03:00
osd: call deref_object_state on recheck_state mismatch in remove_object_from_state 6509cb85b3 
When recheck_state != *object_state, the old object_state reference should be
released via deref_object_state() instead of raw ref_count--. Otherwise, if the
old state has no remaining objects (object_count == 0) and this was its last
reference, it would never be erased from pg.state_dict, leaking memory and state
dictionary entries.
changwei.ye requested review from vitalif 2026-10-15 07:06:12 +03:00
vitalif merged commit 8dd76839f1 into master 2026-10-17 21:21:35 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
vitalif
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#91
No description provided.
Delete Branch "changwei.ye/vitastor:fix-remove-object-from-state"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?