vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

Allow to remove level_placement with an empty modify-pool value #96

Closed
koolkhel wants to merge 1 commits from koolkhel/vitastor:cli-level-placement into master
pull from: koolkhel/vitastor:cli-level-placement
merge into: vitalif:master
Conversation 1 Commits 1 Files Changed 5 +35 -14
koolkhel commented 2026-10-25 16:14:44 +03:00
Contributor
Copy Link

Description

An empty --level_placement was dropped before the merge with the old
pool config, so the old rules stayed and could not be removed at all,
and a malformed value was silently dropped the same way. Make an empty
value remove the key, which the monitor treats as no extra rules, and
refuse a value that is not =[,...] with EINVAL.

Tested: tests/test_level_placement.sh (extended), fails without the fix and passes with it.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description An empty --level_placement was dropped before the merge with the old pool config, so the old rules stayed and could not be removed at all, and a malformed value was silently dropped the same way. Make an empty value remove the key, which the monitor treats as no extra rules, and refuse a value that is not <level>=<rule>[,...] with EINVAL. Tested: tests/test_level_placement.sh (extended), fails without the fix and passes with it. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 1 commit 2026-10-25 16:14:45 +03:00
Allow to remove level_placement with an empty modify-pool value b7efe16836 
An empty --level_placement was dropped before the merge with the old
pool config, so the old rules stayed and could not be removed at all,
and a malformed value was silently dropped the same way. Make an empty
value remove the key, which the monitor treats as no extra rules, and
refuse a value that is not <level>=<rule>[,...] with EINVAL.
koolkhel commented 2026-10-25 16:17:02 +03:00
Author
Contributor
Copy Link

Applied to master as 32421ed4, closing.

Applied to master as 32421ed4, closing.
koolkhel closed this pull request 2026-10-25 16:17:02 +03:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#96
No description provided.
Delete Branch "koolkhel/vitastor:cli-level-placement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?