vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

Limit pg_size to 64 in vitastor-cli create-pool and modify-pool #97

Closed
koolkhel wants to merge 1 commits from koolkhel/vitastor:cli-pg-size-limit into master
pull from: koolkhel/vitastor:cli-pg-size-limit
merge into: vitalif:master
Conversation 1 Commits 1 Files Changed 6 +38 -8
koolkhel commented 2026-10-25 16:14:47 +03:00
Contributor
Copy Link

Description

The CLI accepted pg_size up to 256, but clients and OSDs skip a pool
with pg_size > 64 and the monitor refuses it, so such a pool was
created or switched to a size nobody could serve, without an error.
Refuse pg_size > 64 with EINVAL, also with --force.

Tested: new tests/test_pool_pg_size_limit.sh: without the fix create-pool -s 65 --force and --ec 62+3 succeed and the CLI then prints "Pool 2 has invalid pg_size, skipping pool"; with it they fail with EINVAL.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description The CLI accepted pg_size up to 256, but clients and OSDs skip a pool with pg_size > 64 and the monitor refuses it, so such a pool was created or switched to a size nobody could serve, without an error. Refuse pg_size > 64 with EINVAL, also with --force. Tested: new tests/test_pool_pg_size_limit.sh: without the fix `create-pool -s 65 --force` and `--ec 62+3` succeed and the CLI then prints "Pool 2 has invalid pg_size, skipping pool"; with it they fail with EINVAL. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 1 commit 2026-10-25 16:14:47 +03:00
Limit pg_size to 64 in vitastor-cli create-pool and modify-pool b5e5b6af01 
The CLI accepted pg_size up to 256, but clients and OSDs skip a pool
with pg_size > 64 and the monitor refuses it, so such a pool was
created or switched to a size nobody could serve, without an error.
Refuse pg_size > 64 with EINVAL, also with --force.
koolkhel commented 2026-10-25 16:17:03 +03:00
Author
Contributor
Copy Link

Applied to master as 4b5442e8 (test merged into test_modify_pool.sh in cd2ccf9f), closing.

Applied to master as 4b5442e8 (test merged into test_modify_pool.sh in cd2ccf9f), closing.
koolkhel closed this pull request 2026-10-25 16:17:04 +03:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#97
No description provided.
Delete Branch "koolkhel/vitastor:cli-pg-size-limit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?