vitalif/vitastor
5
6
Fork 12
Code Issues 4 Pull Requests 6 Actions Releases 111 Wiki Activity

Fix vitastor-cli ls-pgs DEGRADED column and lost errors #99

Closed
koolkhel wants to merge 2 commits from koolkhel/vitastor:cli-ls-pgs into master
pull from: koolkhel/vitastor:cli-ls-pgs
merge into: vitalif:master
Conversation 1 Commits 2 Files Changed 3 +51 -1
koolkhel commented 2026-10-25 16:14:52 +03:00
Contributor
Copy Link

Description

  • Fix vitastor-cli ls-pgs DEGRADED column showing misplaced data. The table column used the fmt_misplaced key, so it repeated MISPLACED: PGs with 64 degraded objects showed DEGRADED 0 B. The JSON output was correct.
  • Fix vitastor-cli ls-pgs printing an empty table instead of an error. When the pool was not found or the etcd request failed, loop() still ran format_pgs(), which replaced the error with a table built from the pool config: ls-pgs --pool nosuchpool printed only the table header instead of "Pool nosuchpool not found".

Tested: new tests/test_pg_ls.sh covers both; each check fails without its fix and passes with it.

Contributor Name

Yury Luneff (MIND Software LLC, https://mindsw.io)

CLA

### Description - **Fix vitastor-cli ls-pgs DEGRADED column showing misplaced data.** The table column used the `fmt_misplaced` key, so it repeated MISPLACED: PGs with 64 degraded objects showed `DEGRADED 0 B`. The JSON output was correct. - **Fix vitastor-cli ls-pgs printing an empty table instead of an error.** When the pool was not found or the etcd request failed, `loop()` still ran `format_pgs()`, which replaced the error with a table built from the pool config: `ls-pgs --pool nosuchpool` printed only the table header instead of "Pool nosuchpool not found". Tested: new tests/test_pg_ls.sh covers both; each check fails without its fix and passes with it. ### Contributor Name Yury Luneff (MIND Software LLC, https://mindsw.io) ### CLA - [x] I accept Vitastor CLA agreement: https://git.yourcmc.ru/vitalif/vitastor/src/branch/master/CLA-en.md
koolkhel added 2 commits 2026-10-25 16:14:53 +03:00
Fix vitastor-cli ls-pgs DEGRADED column showing misplaced data 19d20291ba 
The DEGRADED column of the ls-pgs table used the fmt_misplaced key, so
it repeated MISPLACED and never showed degraded data. The JSON output
was correct.
Fix vitastor-cli ls-pgs printing an empty table instead of an error fe85092910 
When the pool was not found or the etcd request failed, load_pg_stats()
stored the error, but loop() still ran format_pgs() which replaced the
message with a table built from the pool config. ls-pgs then printed
only a table header, or a table without stats, instead of the error.
vitalif commented 2026-10-25 22:23:23 +03:00
Owner
Copy Link

Замержил без тестов, мелкие правки

Замержил без тестов, мелкие правки
vitalif closed this pull request 2026-10-25 22:23:24 +03:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
vitalif
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vitalif/vitastor#99
No description provided.
Delete Branch "koolkhel/vitastor:cli-ls-pgs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?